-
Notifications
You must be signed in to change notification settings - Fork 52
change the toast component content props from string to react-node #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: dad5a18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4cfd203 to
9cba590
Compare
ddf8b35 to
9177c1a
Compare
Codecov Report
@@ Coverage Diff @@
## next-v1 #894 +/- ##
===========================================
+ Coverage 69.01% 69.61% +0.60%
===========================================
Files 205 205
Lines 2872 2873 +1
Branches 791 791
===========================================
+ Hits 1982 2000 +18
+ Misses 775 759 -16
+ Partials 115 114 -1
Continue to review full report at Codecov.
|
81d8b5b to
f071ff0
Compare
Chromatic Report🚀 Congratulations! Your build was successful! |
This comment was marked as outdated.
This comment was marked as outdated.
sungik-choi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset을 추가해주세요(영문)! semantic-release에서 changeset으로 변경하면서, 커밋으로 릴리즈 노트를 자동으로 생성해주지 않기 때문에 버전업에 관련된 변경사항에 대해 개발자가 직접 추가해주어야합니다.
- PR 제목을 영문으로 변경해주시면 감사하겠습니다 🙏 오픈소스임을 고려해서 PR 제목 등은 영문으로 작성하는 방식으로 맞추려고 해요(#895)
9f1bca1 to
01630dd
Compare
.changeset/witty-bananas-return.md
Outdated
| "@channel.io/bezier-react": patch | ||
| --- | ||
|
|
||
| refactor(toast): change toast content props "string" to "react-noe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| refactor(toast): change toast content props "string" to "react-noe" | |
| refactor(toast): change toast content props "string" to "react-node" |
typo
| /** | ||
| * @deprecated use React.ReactNode content props instead. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| preset={preset} | ||
| appearance={appearance} | ||
| content={content} | ||
| content={content || ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ToastElement에서 default로 ''를 채워주는데, fallback이 필요한가요?
f8481ac#diff-85ac2201c8cd87922f19fcf93d3b985de850225c6ea38d267ca63ab0f4a6a99aR21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어제는 잘 안보였는데, 다시보니까 Required(ToastElementProps에서)랑 ReactNode에서 차이가 발생된거였네요.
export type ToastContent = NonNullable<React.ReactNode>로 변경하면 될것 같습니다.
- add toast controller test - add toast content type
Self Checklist
Summary
Details
Screen.Recording.2022-07-26.at.13.34.00.mov
Browser Compatibility
OS / Engine 호환성을 반드시 확인해주세요.
Windows
macOS
References
https://github.com/channel-io/ch-desk-web/issues/10597