Skip to content

Conversation

@Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Jul 8, 2022

Summary

  • Switch handle의 색상이 다크모드에서 잘못 표시되는 버그를 수정합니다.

Details

  • handle의 bgColor를 bgtxt-absolute-white-dark로 옳게 지정하였으나, elevation의 css에 bgColor 속성이 override되어 absolute color가 제대로 적용되지 않고 있었습니다.
    • elevation 설정을 위로 올려 해결합니다.

Browser Compatibility

OS / Engine 호환성을 반드시 확인해주세요.

Windows

  • Chrome - Blink
  • Edge - Blink
  • Firefox - Gecko (Option)

macOS

  • Chrome - Blink
  • Edge - Blink
  • Safari - WebKit
  • Firefox - Gecko (Option)

References

@Dogdriip Dogdriip added the fix PR related to bug fix label Jul 8, 2022
@Dogdriip Dogdriip self-assigned this Jul 8, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2022

🦋 Changeset detected

Latest commit: 5ada881

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #867 (5ada881) into next-v1 (6d6fb93) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           next-v1     #867   +/-   ##
========================================
  Coverage    68.98%   68.98%           
========================================
  Files          204      204           
  Lines         2870     2870           
  Branches       788      788           
========================================
  Hits          1980     1980           
  Misses         775      775           
  Partials       115      115           
Impacted Files Coverage Δ
...react/src/components/Forms/Switch/Switch.styled.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6fb93...5ada881. Read the comment docs.

@Dogdriip Dogdriip merged commit 7d1fdc7 into channel-io:next-v1 Jul 9, 2022
@Dogdriip Dogdriip deleted the fix/switch-handle-bg-color branch July 9, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants