Skip to content

Conversation

@kimminkyung94
Copy link
Contributor

Please check the changed part!

This Pull Request was generated by bezier-figma-plugin.

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022

🦋 Changeset detected

Latest commit: 3121d02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #862 (3121d02) into next-v1 (fe83a2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           next-v1     #862   +/-   ##
========================================
  Coverage    68.94%   68.94%           
========================================
  Files          204      204           
  Lines         2866     2866           
  Branches       787      787           
========================================
  Hits          1976     1976           
  Misses         775      775           
  Partials       115      115           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83a2f...3121d02. Read the comment docs.

Copy link
Contributor

@inhibitor1217 inhibitor1217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 그런데 항상 모든 아이콘의 blob이 바뀌어야 하는 건가용?

@aooen
Copy link
Contributor

aooen commented Jul 6, 2022

오호 그런데 항상 모든 아이콘의 blob이 바뀌어야 하는 건가용?

이번이 처음 integration 돌리는거라 그런듯 하네요

@sungik-choi sungik-choi added the feat:icon Issue of PR related to a new icon (auto-generated) label Jul 6, 2022
@sungik-choi
Copy link
Contributor

오호 그런데 항상 모든 아이콘의 blob이 바뀌어야 하는 건가용?

  • 변경사항이 없는데 diff가 있는 아이콘은 왜 그런지 잘 모르겠어요. 아마도... 피그마 내부 로직에 미묘하게 차이가 생긴듯 하고 @aooen 말씀대로 나중에 실행했을 땐 변한 부분만 적용되지 않을까 싶습니다.
  • 현재는 추가/삭제/이름 변경 등 케이스를 쉽게 커버하려고 전체 아이콘을 모두 갈아끼우는 방식으로 구현되어있는데, 디자인팀에서 추가된 아이콘만 선택해서 업데이트하고 싶다는 니즈도 있어서 어떻게 해결하면 좋을지 고민입니다. blob 생성하는 과정이 단순히 빨라지면 해결될 거 같기도 하구요. 의견 주시면 감사하겠습니다!

@sungik-choi sungik-choi force-pushed the update-icons-1657085568490 branch from f407659 to 3121d02 Compare July 6, 2022 16:07
@sungik-choi sungik-choi merged commit 7d15371 into next-v1 Jul 7, 2022
@sungik-choi sungik-choi deleted the update-icons-1657085568490 branch July 7, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat:icon Issue of PR related to a new icon (auto-generated)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants