Skip to content

프로젝트 LICENSE를 Apache License 2.0으로 변경 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 8, 2022
Merged

프로젝트 LICENSE를 Apache License 2.0으로 변경 #861

merged 14 commits into from
Jul 8, 2022

Conversation

@Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Jul 6, 2022

Summary

  • 프로젝트 LICENSE를 Apache License 2.0으로 변경하고, CONTRIBUTING.md 등의 기존 문서에서 이를 반영합니다.

Details

Closes #805

References

@Dogdriip Dogdriip added the documentation Issue or PR that improvements or additions to documentation label Jul 6, 2022
@Dogdriip Dogdriip self-assigned this Jul 6, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: f530f95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
bezier-figma-plugin Patch
@channel.io/bezier-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #861 (f530f95) into next-v1 (fe83a2f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           next-v1     #861   +/-   ##
========================================
  Coverage    68.94%   68.94%           
========================================
  Files          204      204           
  Lines         2866     2866           
  Branches       787      787           
========================================
  Hits          1976     1976           
  Misses         775      775           
  Partials       115      115

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83a2f...f530f95. Read the comment docs.

aooen
aooen suggested changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@aooen aooen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bezier-react/packages/bezier-react/package.json

Line 53 in fe83a2f

"license": "ISC",

여기도 바꿔주세요~

sungik-choi
sungik-choi reviewed Jul 6, 2022
View reviewed changes
aooen
aooen reviewed Jul 6, 2022
View reviewed changes
sungik-choi
sungik-choi reviewed Jul 6, 2022
View reviewed changes
sungik-choi
sungik-choi reviewed Jul 6, 2022
View reviewed changes
packages/bezier-react/package.json
"channel"
],
"author": "Channel Corp.",
"license": "ISC",
Copy link
Contributor

@sungik-choi sungik-choi Jul 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"license": "Apache-2.0" 를 명시하는 편이 좋지 않을지..? 라이센스 파일을 어디에 둬야하는지 저도 잘 모르겠네요 🤔

Copy link
Contributor Author

@Dogdriip Dogdriip Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모노레포의 경우 라이센스를 어떻게 관리하는지, 어디까지 적용되는지 명시된 건 찾아볼 수 없네요 😢 일단 각 패키지마다 라이센스를 명시하는 건 맞는 것 같습니다. bezier-figma-plugin은 ISC로 원복할까요, 아니면 이 참에 Apache 2.0을 적용할까요?

Copy link
Contributor

@sungik-choi sungik-choi Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

채널에서 관리하는 라이브러리이니 같이 가는 편이 저는 더 낫다고 생각하는데, 다른 분들 생각은 어떤지 궁금하네요

Copy link
Contributor Author

@Dogdriip Dogdriip Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 Apache를 적용하더라도 당장은 문제가 없으며, 모노레포 내의 각 패키지들이 다른 라이센스를 가지는 경우 레포에는 어떻게 표기해야 하는지 등 명확히 정해진 사항이 없어 일괄적으로 Apache 2.0을 적용했습니다. (문제가 생길 것 같지는 않지만) 나중에 문제가 되더라도 그 때 해결해도 될 것 같아요 💭

sungik-choi
sungik-choi approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 디테일까지 너무 잘 챙겨주셨네요

@Dogdriip Dogdriip merged commit 3a2912f into channel-io:next-v1 Jul 8, 2022
@Dogdriip Dogdriip deleted the docs/apache-license branch July 8, 2022 05:57
@github-actions github-actions bot mentioned this pull request Jul 8, 2022
Merged
@github-actions github-actions bot mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quino0627 quino0627 quino0627 approved these changes

+2 more reviewers

@aooen aooen aooen approved these changes

@sungik-choi sungik-choi sungik-choi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dogdriip Dogdriip

Labels

documentation Issue or PR that improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

프로젝트 라이센스 논의 및 변경

4 participants

@Dogdriip @aooen @quino0627 @sungik-choi