Replace react-docgen-typescript-plugin with Storybook's reactDocgen option
#1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dogdriip
added
the
documentation
🦋 Changeset detectedLatest commit: 11a1305 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 280 280
Lines 3843 3843
Branches 806 806
=======================================
Hits 3356 3356
Misses 414 414
Partials 73 73 ☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
inhibitor1217
approved these changes
Sep 5, 2023
Contributor
Chromatic Report🚀 Congratulations! Your build was successful! |
sungik-choi
approved these changes
Sep 8, 2023
yangwooseong
approved these changes
Sep 8, 2023
Dogdriip
changed the title
@channel.io/react-docgen-typescript-plugin with Storybook's reactDocgen optionreact-docgen-typescript-plugin with Storybook's reactDocgen option
sungik-choi
pushed a commit
that referenced
this pull request
Sep 12, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @channel.io/[email protected] ### Minor Changes - Add Banner to iconName transformation target ([#1562](#1562)) by @yangwooseong ## @channel.io/[email protected] ### Minor Changes - Add script for generating svg file from icons.json ([#1596](#1596)) by @yangwooseong ## @channel.io/[email protected] ### Minor Changes - Allow `iconName` prop of `Button`, `Banner`, `SectionLabel` component to include `BezierIcon` type ([#1562](#1562)) by @yangwooseong ### Patch Changes - Fixed a rendering bug that occurs when using `react-resize-detector` and `asChild`prop of `radix-ui` simultaneously. ([#1577](#1577)) by @yangwooseong - Removed indicator adjusting logic by `react-resize-detector` using css transform property - Replace `@channel.io/react-docgen-typescript-plugin` with Storybook's `reactDocgen` option ([#1594](#1594)) by @Dogdriip ## [email protected] ### Minor Changes - Enhance bezier-figma-plugin running performance ([#1596](#1596)) by @yangwooseong - Remove svg extract process using FigmaAPI and merely send json file that contains svg string - Make icon files based on given json file during Github Action ### Patch Changes - Updated dependencies - @channel.io/[email protected] - @channel.io/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self Checklist
CODEOWNERSfile.Related Issue
Summary
react-docgen-typescript-plugin을 적용하였으나, 이 플러그인이react-docgen-typescriptv1을 사용하는 이슈로 인해 이를 fork한 별도의 플러그인@channel.io/react-docgen-typescript-plugin을 사용하고 있었습니다.react-docgen-typescript-plugin이react-docgen-typescriptv2를 사용하게 됨에 따라, 별도의 플러그인을 제거하고 내장 플러그인을 사용하도록 합니다.Details
Breaking change or not (Yes/No)
References