Skip to content

Conversation

@sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

Fix Avatar not resizing under flex layout.

Details

  • Add flex: none style to avatar wrapper component

Breaking change or not (Yes/No)

No

References

None

@sungik-choi sungik-choi added the fix PR related to bug fix label May 17, 2023
@sungik-choi sungik-choi self-assigned this May 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: 63646bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e3799f) 84.25% compared to head (63646bb) 84.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1359   +/-   ##
========================================
  Coverage    84.25%   84.25%           
========================================
  Files          309      309           
  Lines         3919     3919           
  Branches       804      804           
========================================
  Hits          3302     3302           
  Misses         546      546           
  Partials        71       71           
Impacted Files Coverage Δ
...act/src/components/Avatars/Avatar/Avatar.styled.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sungik-choi sungik-choi merged commit d52a271 into channel-io:next-v1 May 17, 2023
@sungik-choi sungik-choi deleted the fix/avatar-shrink branch May 17, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants