Skip to content

Conversation

@sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

SegmentedControlItem 컴포넌트 내부의 HTMLButtonElement 의 타입을 button으로 변경합니다.

Details

  • 원래는 Radix UI에 의해서 런타임에 type: button 이 주입되어야합니다.
  • 하지만 type 속성을 SegmentedControl 에서 이미 정의하고 사용하고 있어, 오버라이드가 제대로 되지 않은 문제가 있었습니다.
  • type 속성을 명시적으로 button으로 주입하여 해결합니다.
  • HTMLAttributes로 사용될 수 있는 Key의 경우, 컴포넌트의 속성으로 사용하지 않도록 예방책이 필요할 거 같습니다 🤔

Breaking change or not (Yes/No)

No

References

No

@sungik-choi sungik-choi added the fix PR related to bug fix label May 15, 2023
@sungik-choi sungik-choi self-assigned this May 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: c4ea2c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c40d79) 84.25% compared to head (c4ea2c0) 84.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1347   +/-   ##
========================================
  Coverage    84.25%   84.25%           
========================================
  Files          309      309           
  Lines         3919     3919           
  Branches       804      804           
========================================
  Hits          3302     3302           
  Misses         546      546           
  Partials        71       71           
Impacted Files Coverage Δ
...ts/Forms/SegmentedControl/SegmentedControlItem.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 91d69e9 into channel-io:next-v1 May 15, 2023
@sungik-choi sungik-choi deleted the fix/segmented-control-item-button-type branch May 15, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant