Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented May 15, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

SegmentedControlItem 의 컨텐츠 영역 스타일링을 올바르게 수정합니다.

Details

  • 사이드 컨텐츠가 가로축을 기준으로 정렬되도록 수정
  • 사이드 컨텐츠가 인디케이터에 의해 가려지지 않도록 수정

Breaking change or not (Yes/No)

No

References

None

@sungik-choi sungik-choi added the fix PR related to bug fix label May 15, 2023
@sungik-choi sungik-choi self-assigned this May 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: a45f663

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9c40d79) 84.25% compared to head (a45f663) 84.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1343   +/-   ##
========================================
  Coverage    84.25%   84.25%           
========================================
  Files          309      309           
  Lines         3919     3919           
  Branches       804      804           
========================================
  Hits          3302     3302           
  Misses         546      546           
  Partials        71       71           
Impacted Files Coverage Δ
...ts/Forms/SegmentedControl/SegmentedControlItem.tsx 100.00% <ø> (ø)
.../Forms/SegmentedControl/SegmentedControl.styled.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 0feaed9 into channel-io:next-v1 May 15, 2023
@sungik-choi sungik-choi deleted the fix/segmented-control-item branch May 15, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants