-
Notifications
You must be signed in to change notification settings - Fork 52
Implement AlphaSmoothCornersBox component
#1317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AlphaSmoothCornersBox component
#1317
Conversation
🦋 Changeset detectedLatest commit: 8187774 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Report🚀 Congratulations! Your build was successful! |
…margin and blur radius prop
…ent to box-shadow
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1317 +/- ##
===========================================
+ Coverage 77.72% 77.76% +0.04%
===========================================
Files 299 302 +3
Lines 3847 3855 +8
Branches 842 849 +7
===========================================
+ Hits 2990 2998 +8
- Misses 571 577 +6
+ Partials 286 280 -6
☔ View full report in Codecov by Sentry. |
AlphaSmoothCornersBox componentAlphaSmoothCornersBox component
Self Checklist
CODEOWNERSfile.Related Issue
Fixes #1315
Summary
Implement
AlphaSmoothCornersBox.AlphaSmoothCornersBoxis a simpledivelement with smooth corners.It is available by enabling the
SmoothCornersFeature.AlphaSmoothCornersBoxforAvatar's internal implementation.Avatar's border is now implemented as a box-shadow instead of a qseudo element.AlphaSmoothCornersBoxfor ellipsis icon ofAvatarGroup's internal implementation.Details
AlphaSmoothCorners를 구현합니다.CheckableAvatarcomponent to behave as an actual Checkbox #1237 과 함께CheckableAvatar의 내부 구현에AlphaSmoothCorners를 적용하고,smoothCorners믹스인을 제거할 예정입니다.disabled속성을 추가하고,Avatar에도 마찬가지로smoothCorners속성을 추가했습니다(defaulttrue, disabled의 default는false).Avatar의 스타일링을 class name과 css variable을 통한 방식으로 변경합니다. (related to Remove the CSS-in-JS library #1106)Avatar의 border 스타일링이 잘 되어서, 수도 엘리먼트를 사용한 스타일링을 제거합니다.Breaking change or not (Yes/No)
No
References
None