Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Apr 20, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

Change LegacyRadio component to export individually named instead of the LegacyRadio namespace.

- import { LegacyRadio } from '@channel.io/bezier-react'
- type RadioProps = LegacyRadio.RadioProps
- const RadioComponent = LegacyRadio.Radio
+ import { LegacyRadio, type LegacyRadioProps } from '@channel.io/bezier-react'
+ type RadioProps = LegacyRadioProps
+ const RadioComponent = LegacyRadio

Details

  • 일관적인 컨벤션을 위한 변경입니다. 레거시 컴포넌트의 경우에도 특정 네임스페이스에 담아 export하는 방식에서, Alpha** 컴포넌트처럼 컴포넌트명에 Legacy** 를 붙이는 방식으로 변경합니다.

Breaking change or not (Yes/No)

Yes

레거시 Radio 사용처에서 변경이 필요합니다.

References

None

@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Apr 20, 2023
@sungik-choi sungik-choi self-assigned this Apr 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

🦋 Changeset detected

Latest commit: d324de6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (afb87cd) 78.18% compared to head (d324de6) 78.18%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1298   +/-   ##
========================================
  Coverage    78.18%   78.18%           
========================================
  Files          294      294           
  Lines         3796     3796           
  Branches       838      838           
========================================
  Hits          2968     2968           
  Misses         545      545           
  Partials       283      283           
Impacted Files Coverage Δ
...s/bezier-react/src/components/LegacyRadio/index.ts 0.00% <0.00%> (ø)
...t/src/components/LegacyRadio/LegacyRadio.styled.ts 58.82% <100.00%> (ø)
...r-react/src/components/LegacyRadio/LegacyRadio.tsx 85.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 284d3d8 into channel-io:next-v1 Apr 20, 2023
@sungik-choi sungik-choi deleted the refactor/legacy-folder-structure branch April 20, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Issue or PR related to refactoring with no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant