-
Notifications
You must be signed in to change notification settings - Fork 52
Enhance FormControl component
#1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FormControl component
#1265
Conversation
🦋 Changeset detectedLatest commit: 0783cd2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1265 +/- ##
===========================================
- Coverage 78.12% 78.11% -0.02%
===========================================
Files 294 294
Lines 3795 3793 -2
Branches 844 841 -3
===========================================
- Hits 2965 2963 -2
Misses 546 546
Partials 284 284
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
FormControl component
…rom useEffect to callbackRef
2dd5e87 to
0783cd2
Compare
Self Checklist
CODEOWNERSfile.Related Issue
None
Summary
FormControl컴포넌트를 개선합니다.Details
useEffect를 통해 마운트 여부를 체크하던 로직을 Callback ref를 사용한 방식으로 리팩토링합니다. 컨텍스트 사용처에서 더 깔끔한 방식으로 마운트 여부를 체크할 수 있도록 합니다.AlphaStack을 사용하도록 리팩토링합니다.Breaking change or not (Yes/No)
No
References
None