Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Apr 5, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Summary

Remove the 100% width, 100% height style from AlphaStack component

Details

스크린샷 2023-04-05 오후 3 27 25

FormGroup 스타일링이 틀어짐. 우측 참고

  • FormGroup 에서 height: 100% 스타일이 flex-wrap 과 결합 시 의도치 않게 스타일링이 됩니다. 이를 해결합니다.
  • 또한 width, height 100% 스타일은 Stack 컴포넌트의 정책으로 정해진 스타일이기때문에, AlphaStack 컴포넌트에 그대로 옮겨올 필요는 없다고 판단했습니다. (레퍼런스 참고)
  • See FormGroup Component #698

Breaking change or not (Yes/No)

No

References

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: 864b5b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0dd5ed8) 78.12% compared to head (864b5b0) 78.12%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1264   +/-   ##
========================================
  Coverage    78.12%   78.12%           
========================================
  Files          294      294           
  Lines         3795     3795           
  Branches       844      844           
========================================
  Hits          2965     2965           
  Misses         546      546           
  Partials       284      284           
Impacted Files Coverage Δ
...act/src/components/AlphaStack/AlphaStack.styled.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi self-assigned this Apr 5, 2023
@sungik-choi sungik-choi added the fix PR related to bug fix label Apr 5, 2023
@sungik-choi sungik-choi changed the title Fix/alpha stack style Remove the 100% width, 100% height style from AlphaStack component Apr 5, 2023
@sungik-choi sungik-choi force-pushed the fix/alpha-stack-style branch from 0014a9a to 9c7590e Compare April 5, 2023 06:24
@sungik-choi sungik-choi marked this pull request as ready for review April 5, 2023 06:31
@sungik-choi sungik-choi force-pushed the fix/alpha-stack-style branch from 9c7590e to 8b4e05e Compare April 5, 2023 06:34
@sungik-choi sungik-choi merged commit e2b4291 into channel-io:next-v1 Apr 5, 2023
@sungik-choi sungik-choi deleted the fix/alpha-stack-style branch April 5, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants