-
Notifications
You must be signed in to change notification settings - Fork 52
Remove the 100% width, 100% height style from AlphaStack component
#1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 100% width, 100% height style from AlphaStack component
#1264
Conversation
🦋 Changeset detectedLatest commit: 864b5b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1264 +/- ##
========================================
Coverage 78.12% 78.12%
========================================
Files 294 294
Lines 3795 3795
Branches 844 844
========================================
Hits 2965 2965
Misses 546 546
Partials 284 284
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Chromatic Report🚀 Congratulations! Your build was successful! |
AlphaStack component
0014a9a to
9c7590e
Compare
9c7590e to
8b4e05e
Compare
Self Checklist
CODEOWNERSfile.Related Issue
Summary
Remove the 100% width, 100% height style from AlphaStack component
Details
FormGroup에서height: 100%스타일이flex-wrap과 결합 시 의도치 않게 스타일링이 됩니다. 이를 해결합니다.Stack컴포넌트의 정책으로 정해진 스타일이기때문에,AlphaStack컴포넌트에 그대로 옮겨올 필요는 없다고 판단했습니다. (레퍼런스 참고)Breaking change or not (Yes/No)
No
References