Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Mar 27, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None

Summary

Checkbox 컴포넌트의 checked prop에 제네릭 타입을 적용합니다.

Details

checked 의 타입, CheckedStateboolean | 'indeterminate' 입니다. 여기서 'indeterminate' 타입은 체크박스 유즈 케이스상 사용처가 거의 없고, 대부분은 boolean 으로만 상태를 컨트롤합니다. 이러한 대부분의 케이스에서 불필요한 'indeterminate' 타입이 에러를 발생시키는 불편함을 해소하기위해 checked prop에 제네릭 타입을 적용합니다.

Breaking change or not (Yes/No)

No

References

None

@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Mar 27, 2023
@sungik-choi sungik-choi self-assigned this Mar 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

🦋 Changeset detected

Latest commit: d45e601

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (64d3d58) 77.93% compared to head (d45e601) 77.93%.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1244   +/-   ##
========================================
  Coverage    77.93%   77.93%           
========================================
  Files          298      298           
  Lines         3802     3802           
  Branches       842      842           
========================================
  Hits          2963     2963           
  Misses         554      554           
  Partials       285      285           
Impacted Files Coverage Δ
...t/src/components/Forms/Checkbox/Checkbox.styled.ts 100.00% <100.00%> (ø)
...r-react/src/components/Forms/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi requested review from Dogdriip and removed request for Dogdriip March 27, 2023 05:01
@sungik-choi sungik-choi merged commit 825bd8a into channel-io:next-v1 Mar 27, 2023
@sungik-choi sungik-choi deleted the enhance/checkbox-checked-type branch March 27, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant