Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Mar 13, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Fixes #638

Summary

컨텐츠를 가운데 정렬할 때 사용되는 레이아웃 컴포넌트인 AlphaCenter 컴포넌트를 구현합니다.

Details

  • Implement Center component #638 참고.
  • 디자인 시스템 리디자인이 진행되면서 내부 구현/인터페이스가 변경될 수 있으므로, Alpha prefix를 추가했습니다.

Breaking change or not (Yes/No)

No

References

없음

@sungik-choi sungik-choi added rfc feat:component Issue or PR related to a new component labels Mar 13, 2023
@sungik-choi sungik-choi self-assigned this Mar 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: 3514d4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.01 🎉

Comparison is base (59bfddc) 77.57% compared to head (3514d4d) 77.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1189      +/-   ##
===========================================
+ Coverage    77.57%   77.58%   +0.01%     
===========================================
  Files          291      294       +3     
  Lines         3803     3810       +7     
  Branches       846      846              
===========================================
+ Hits          2950     2956       +6     
- Misses         558      559       +1     
  Partials       295      295              
Impacted Files Coverage Δ
...s/bezier-react/src/components/AlphaCenter/index.ts 0.00% <0.00%> (ø)
...t/src/components/AlphaCenter/AlphaCenter.styled.ts 100.00% <100.00%> (ø)
...r-react/src/components/AlphaCenter/AlphaCenter.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit cc7270d into channel-io:next-v1 Mar 16, 2023
@sungik-choi sungik-choi deleted the feat/alpha-center branch March 16, 2023 08:21
@dinohan dinohan mentioned this pull request Apr 20, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat:component Issue or PR related to a new component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Center component

1 participant