Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Feb 27, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

없음

Summary

인터페이스에 정의되어 있으나 Overlay 에 제대로 전달되고 있지 않던 속성이 올바르게 전달되도록 수정합니다.

Details

  • 불필요한 타입 단언 제거

Breaking change or not (Yes/No)

No

References

없음

@sungik-choi sungik-choi added the fix PR related to bug fix label Feb 27, 2023
@sungik-choi sungik-choi self-assigned this Feb 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2023

🦋 Changeset detected

Latest commit: 2a7e5a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 83.57% // Head: 83.56% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2a7e5a1) compared to base (89f1883).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1143      +/-   ##
===========================================
- Coverage    83.57%   83.56%   -0.02%     
===========================================
  Files          291      291              
  Lines         3739     3742       +3     
  Branches       774      775       +1     
===========================================
+ Hits          3125     3127       +2     
- Misses         537      538       +1     
  Partials        77       77              
Impacted Files Coverage Δ
...es/bezier-react/src/components/Overlay/Overlay.tsx 92.39% <80.00%> (-0.95%) ⬇️
...ier-react/src/components/Overlay/Overlay.styled.ts 90.00% <100.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit 53d83ba into channel-io:next-v1 Feb 28, 2023
@sungik-choi sungik-choi deleted the fix/overlay-props branch February 28, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants