-
Notifications
You must be signed in to change notification settings - Fork 52
Enhance RadioGroup component
#1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance RadioGroup component
#1131
Conversation
🦋 Changeset detectedLatest commit: 50bfcf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 72.88% // Head: 72.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1131 +/- ##
===========================================
- Coverage 72.88% 72.87% -0.02%
===========================================
Files 366 366
Lines 4404 4405 +1
Branches 854 855 +1
===========================================
Hits 3210 3210
Misses 1119 1119
- Partials 75 76 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
…List<Element> type
977ede6 to
82c004f
Compare
RadioGroup component
packages/bezier-react/src/components/Forms/RadioGroup/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/bezier-react/src/components/Forms/RadioGroup/RadioGroup.tsx
Outdated
Show resolved
Hide resolved
| * </RadioGroup> | ||
| * ``` | ||
| */ | ||
| export const RadioGroup = forwardRef(RadioGroupImpl) as <Value extends string>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 공유 감사합니다. 저도 꼼꼼히 확인해봐야할듯.
Self Checklist
CODEOWNERSfile.Related Issue
없음
Summary
RadioGroup,Radio컴포넌트를 개선합니다.Details
string외enum등의 케이스에서도 타입 에러 없이 사용할 수 있도록 합니다.RadioGroup의children타입을React.ReactNode로 변경합니다. 다양한 유즈케이스에서도 타입 에러 없이 잘 동작하도록 변경합니다.Radio에 children이 존재하는 케이스에만 내부 라벨을 렌더하도록 변경합니다. 라벨이 없는 유즈케이스를 커버하기 위한 변경입니다.Breaking change or not (Yes/No)
No
References
없음