-
Notifications
You must be signed in to change notification settings - Fork 52
refactor(modal): change from inset to top..left style to support legacy version chrome browser #1110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cy version chrome browser
🦋 Changeset detectedLatest commit: 3b24ea2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 72.75% // Head: 72.75% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1110 +/- ##
========================================
Coverage 72.75% 72.75%
========================================
Files 362 362
Lines 4371 4371
Branches 852 852
========================================
Hits 3180 3180
Misses 1117 1117
Partials 74 74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
6b618ce to
c8524f5
Compare
Modal style to support legacy browser and various container
Dogdriip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦋
8e0cb06 to
3b24ea2
Compare
Self Checklist
CODEOWNERSfile.Related Issue
없음.
Summary
Modal컴포넌트의 스타일을 개선합니다.Details
insetCSS 속성의 경우, 몇몇 구버전 브라우저에서 지원하지 않습니다. 동일한 기능을 하는 CSS 속성으로 변경합니다.Breaking change or not (Yes/No)
No
References