Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Jan 20, 2023

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

없음.

Summary

Modal 컴포넌트의 스타일을 개선합니다.

Details

inset CSS 속성의 경우, 몇몇 구버전 브라우저에서 지원하지 않습니다. 동일한 기능을 하는 CSS 속성으로 변경합니다.

Breaking change or not (Yes/No)

No

References

@sungik-choi sungik-choi added the enhancement Issues or PR related to making existing features better label Jan 20, 2023
@sungik-choi sungik-choi self-assigned this Jan 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2023

🦋 Changeset detected

Latest commit: 3b24ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 72.75% // Head: 72.75% // No change to project coverage 👍

Coverage data is based on head (3b24ea2) compared to base (eb803d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1110   +/-   ##
========================================
  Coverage    72.75%   72.75%           
========================================
  Files          362      362           
  Lines         4371     4371           
  Branches       852      852           
========================================
  Hits          3180     3180           
  Misses        1117     1117           
  Partials        74       74           
Impacted Files Coverage Δ
...-react/src/components/Modals/Modal/Modal.styled.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi changed the title Enhance Modal style to support legacy browser and various container refactor(modal): change from inset to top..left style to support legacy version chrome browser Jan 20, 2023
@sungik-choi sungik-choi added the refactoring Issue or PR related to refactoring with no functional changes label Jan 20, 2023
Copy link
Contributor

@Dogdriip Dogdriip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦋

@sungik-choi sungik-choi merged commit b406a26 into channel-io:next-v1 Jan 30, 2023
@sungik-choi sungik-choi deleted the fix/modal-style branch January 30, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants