Remove and re-implement `lodash-es` #1079

annie1229 · 2022-12-20T06:55:19Z

Self Checklist

I wrote a PR title in English.
I added an appropriate label to the PR.
I wrote a commit message in English.
I wrote a commit message according to the Conventional Commits specification.
I added the appropriate changeset for the changes.
[Component] I wrote a unit test about the implementation.
[Component] I wrote a storybook document about the implementation.
[Component] I tested the implementation in various browsers.
- Windows: Chrome, Edge, (Optional) Firefox
- macOS: Chrome, Edge, Safari, (Optional) Firefox
[New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Summary

lodash-es가 사용되던 로직을 직접 구현한 util 함수로 변경하고, lodash-es를 제거합니다.

as-is (1.06MB)	to-be (944.21KB)

(참고) 기존에 올렸었던 as-is(붉은색 사진)은 yarn clean을 하지 않은 상태로 빌드되었었습니다.
yarn clean -> yarn install -> yarn build 동일한 과정으로 다시 측정한 파일로 다시 올렸습니다!

Details

Breaking change or not (Yes/No)

No

References

changeset-bot · 2022-12-20T06:55:33Z

🦋 Changeset detected

Latest commit: 48f1c05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@channel.io/bezier-react	Patch
bezier-figma-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2022-12-20T08:27:12Z

Codecov Report

Base: 83.47% // Head: 83.60% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (48f1c05) compared to base (3224af6).
Patch coverage: 88.83% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           next-v1    #1079      +/-   ##
===========================================
+ Coverage    83.47%   83.60%   +0.13%     
===========================================
  Files          285      289       +4     
  Lines         3570     3709     +139     
  Branches       714      769      +55     
===========================================
+ Hits          2980     3101     +121     
- Misses         517      533      +16     
- Partials        73       75       +2

Impacted Files	Coverage Δ
.../bezier-react/src/components/Toast/ToastContext.ts	`0.00% <0.00%> (ø)`
...ckages/bezier-react/src/foundation/GlobalStyle.tsx	`33.33% <0.00%> (-9.53%)`	⬇️
...rc/components/Forms/Inputs/TextField/TextField.tsx	`58.82% <50.00%> (+0.34%)`	⬆️
packages/bezier-react/src/utils/storyUtils.ts	`87.50% <50.00%> (+1.78%)`	⬆️
packages/bezier-react/src/utils/objectUtils.ts	`77.35% <77.35%> (ø)`
packages/bezier-react/src/utils/stringUtils.ts	`66.66% <82.35%> (+6.66%)`	⬆️
packages/bezier-react/src/utils/typeUtils.ts	`90.90% <90.90%> (ø)`
...ier-react/src/components/Avatars/Avatar/Avatar.tsx	`85.29% <100.00%> (+0.44%)`	⬆️
...src/components/Avatars/AvatarGroup/AvatarGroup.tsx	`86.95% <100.00%> (ø)`
...ages/bezier-react/src/components/Banner/Banner.tsx	`92.59% <100.00%> (ø)`
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-12-21T05:03:54Z

Chromatic Report

🚀 Congratulations! Your build was successful!

sungik-choi · 2022-12-26T08:39:49Z

packages/bezier-react/scripts/icon-index-template.js


  filePaths.forEach(filePath => {
    const basename = path.basename(filePath, path.extname(filePath))
+    const kebabCase = (value) => value


forEach callback 함수 바깥(defaultIndexTemplate 바깥)으로 분리할 수 있을 거 같습니다.

sungik-choi · 2022-12-26T08:41:01Z

packages/bezier-react/src/components/Avatars/Avatar/Avatar.tsx

-  onClick = noop,
-  onMouseEnter = noop,
-  onMouseLeave = noop,
+  onClick = () => {},


noop 라는 함수가 별도로 있으면 좋겠네요! (+ 테스트 코드)

sungik-choi · 2022-12-26T08:43:49Z

packages/bezier-react/src/components/Button/Button.tsx

 ) : VariantTuple[] {
  function toArray<T>(items: T | T[]): T[] {
-    return isArray(items) ? items : [items]
+    return Array.isArray(items) ? items : [items]


is*** 같은 함수들이 typeUtils 에 모두 구현되어있는 편이 사용하는 입장에서 예측 가능할 거 같아요.

sungik-choi · 2022-12-26T08:49:42Z

어디까지 유틸함수화할 것인가라고 생각해보면 어렵네요. 예를 들어 Object.entries 같은 메서드를 entries 라는 별도의 유틸함수로 분리하고, 테스트를 추가하는 게 맞을지..? 다른 분들 의견도 궁금합니다.

sungik-choi

👍👍👍

Dogdriip

👍

Dogdriip · 2023-01-25T04:23:48Z

packages/bezier-react/src/utils/typeUtils.ts

+  return !value
+}
+
+export function noop() {}


마이너 코멘트: noop 함수가 typeUtils에 있는 이유가 따로 있을까요? 타입을 체크하는 함수는 확실히 아닌 것 같아서, functionUtils 등 다른 파일로 빼는 게 어떨까 제안합니다.

CHEWCHEWW

👍👍👍

… isRegExp(typeUtils)

…includes number

…ttenly

…ction

annie1229 added enhancement Issues or PR related to making existing features better build Issue or PR related to build system labels Dec 20, 2022

annie1229 self-assigned this Dec 20, 2022

annie1229 force-pushed the enhance/migration-lodash-es branch from 0e5682b to 4811263 Compare December 20, 2022 08:25

annie1229 force-pushed the enhance/migration-lodash-es branch from 4811263 to 5072bd5 Compare December 21, 2022 04:57

annie1229 force-pushed the enhance/migration-lodash-es branch 3 times, most recently from 440ddb0 to bf3adfb Compare December 22, 2022 07:32

annie1229 marked this pull request as ready for review December 22, 2022 08:41

annie1229 requested review from CHEWCHEWW, Dogdriip, dinohan, guswnsxodlf, quino0627 and sungik-choi as code owners December 22, 2022 08:41

sungik-choi reviewed Dec 26, 2022

View reviewed changes

annie1229 force-pushed the enhance/migration-lodash-es branch 4 times, most recently from 251b639 to 281f35c Compare January 2, 2023 09:05

sungik-choi requested a review from jeff-tbd January 5, 2023 06:07

dinohan approved these changes Jan 9, 2023

View reviewed changes

sungik-choi approved these changes Jan 9, 2023

View reviewed changes

guswnsxodlf approved these changes Jan 9, 2023

View reviewed changes

Dogdriip approved these changes Jan 25, 2023

View reviewed changes

CHEWCHEWW approved these changes Feb 2, 2023

View reviewed changes

annie1229 added 24 commits February 24, 2023 15:46

refactor(isequal): migration isEqual lodash-es -> objectUtils and add…

ac155de

… isRegExp(typeUtils)

refactor(throttle): migration throttle lodash-es -> timingUtils

ad285d0

test(typeutils): add typeUtils test

36d188f

test(stringutils): add toString, camelCase test in stringUtils

8929d98

test(objectutils): add test objectUtils

eaaf561

test(arrayutils): add test arrayUtils(compact, flattenDeep)

aa10d71

test(numberutils): add test numberUtils and fix range function

04160a9

test(timingutils): add test timingUtils

53f000f

feat(kebabcase): migration kebabCase lodash-es -> stringUtils

9485922

test(stringutils): add test kebabCase

abb120f

build(npm): remove lodash-es

4f7513a

fix(arrayutils): fix flattenDeep return type unknown[] -> T[]

644a7d7

fix: fix lint error, change the import order

ea622ab

fix(stringutils): fix kebabCase and camelCase logic when input value …

94d4291

…includes number

fix(timingutils): fix time-related throttle test code failing intermi…

3126b21

…ttenly

chore(changeset): add changeset

a76f01f

fix: remove lodash-es related code added during rebase

dc99497

refactor(stringutils): refactor kebabCase RegExp

0808672

refactor(kebabcase): change the location of the declation outside fun…

2313d08

…ction

refactor(typeutils): add isArray, isInteger, isNaN

4ab2827

refactor(typeutils): add noop and migration arrow function () => {}

cf7a579

fix: remove lodash-es related code added during rebase

a99203b

refactor(noop): move to functionUtils

755eeda

test(arrayutils): rebase and delete unnecessary code

e6e86fb

annie1229 force-pushed the enhance/migration-lodash-es branch from 345e096 to e6e86fb Compare February 24, 2023 07:21

refactor(timingutils): delete unused util

48f1c05

annie1229 merged commit 85d04e7 into channel-io:next-v1 Feb 24, 2023

annie1229 deleted the enhance/migration-lodash-es branch February 24, 2023 07:52

github-actions bot mentioned this pull request Feb 24, 2023

ci(changesets): version packages (next-v1) #1142

Merged

github-actions bot mentioned this pull request May 30, 2023

ci(changesets): version packages #1369

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove and re-implement `lodash-es` #1079

Remove and re-implement `lodash-es` #1079

Uh oh!

annie1229 commented Dec 20, 2022 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 20, 2022 •

edited

Loading

Uh oh!

codecov bot commented Dec 20, 2022 •

edited

Loading

Uh oh!

github-actions bot commented Dec 21, 2022 •

edited

Loading

Uh oh!

sungik-choi Dec 26, 2022

Uh oh!

sungik-choi Dec 26, 2022

Uh oh!

sungik-choi Dec 26, 2022

Uh oh!

sungik-choi commented Dec 26, 2022 •

edited

Loading

Uh oh!

sungik-choi left a comment

Uh oh!

Dogdriip left a comment

Uh oh!

Dogdriip Jan 25, 2023

Uh oh!

CHEWCHEWW left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Remove and re-implement lodash-es #1079

Remove and re-implement lodash-es #1079

Uh oh!

Conversation

annie1229 commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Self Checklist

Related Issue

Summary

Details

Breaking change or not (Yes/No)

References

Uh oh!

changeset-bot bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chromatic Report

Uh oh!

sungik-choi Dec 26, 2022

Choose a reason for hiding this comment

Uh oh!

sungik-choi Dec 26, 2022

Choose a reason for hiding this comment

Uh oh!

sungik-choi Dec 26, 2022

Choose a reason for hiding this comment

Uh oh!

sungik-choi commented Dec 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sungik-choi left a comment

Choose a reason for hiding this comment

Uh oh!

Dogdriip left a comment

Choose a reason for hiding this comment

Uh oh!

Dogdriip Jan 25, 2023

Choose a reason for hiding this comment

Uh oh!

CHEWCHEWW left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Remove and re-implement `lodash-es` #1079

Remove and re-implement `lodash-es` #1079

annie1229 commented Dec 20, 2022 •

edited

Loading

changeset-bot bot commented Dec 20, 2022 •

edited

Loading

codecov bot commented Dec 20, 2022 •

edited

Loading

github-actions bot commented Dec 21, 2022 •

edited

Loading

sungik-choi commented Dec 26, 2022 •

edited

Loading