-
Notifications
You must be signed in to change notification settings - Fork 52
Re-implement Radio component using RadioGroup in Radix UI
#1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-implement Radio component using RadioGroup in Radix UI
#1071
Conversation
🦋 Changeset detectedLatest commit: c905017 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 72.75% // Head: 72.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1071 +/- ##
===========================================
+ Coverage 72.75% 72.88% +0.13%
===========================================
Files 362 366 +4
Lines 4371 4404 +33
Branches 852 855 +3
===========================================
+ Hits 3180 3210 +30
- Misses 1117 1119 +2
- Partials 74 75 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
712c8e9 to
e0d0b81
Compare
Radio component using RadioGroup in Radix UIRadio component using RadioGroup in Radix UI
| direction = 'vertical', | ||
| ...rest | ||
| }: RadioGroupProps, forwardedRef: React.Ref<HTMLDivElement>) { | ||
| const formFieldProps = useFormFieldProps(rest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FormControl 컨텍스트 아래에서 사용할 수 있도록합니다. 하위 Item에 대한 컨트롤은 Radix 라이브러리-RadioGroupPrimitive.Root-에서 담당하므로, 개별 Item(Radio)에서 FormFieldProps를 사용하는게 아닌 RadioGroup 에서 FormFieldProps를 사용하도록 구현했습니다. 잘 동작하려면, 제시한 예시처럼 Radio 는 무조건 RadioGroup 하위에서만 사용되어야 합니다.
| ` | ||
| } | ||
|
|
||
| export function touchableHover(interpolation: InjectedInterpolation): InjectedInterpolation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shared-components와 front에서 이거 쓰도록 수정해야겠네요.
a49a830 to
66bac1b
Compare
|
채널 데스크 어플리케이션에 모달 마이그레이션 작업 완료 이후 머지할 예정입니다. |
Self Checklist
CODEOWNERSfile.Related Issue
Fixes #709
Summary
RadioGroup컴포넌트를 구현하고,Radio컴포넌트를 재구현합니다.Details
RadioGroup.Root컴포넌트를 사용하여RadioGroup컴포넌트를 구현합니다.RadioGroup.Item컴포넌트를 사용하여Radio컴포넌트를 재구현합니다.Breaking change or not (Yes/No)
Yes
Radiocomponent is now exported with namespaceLEGACY__Radio. It will be deprecated.Radiocomponent must be used with the newRadioGroupcomponent. See below.References