Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Dec 6, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Summary

Text 컴포넌트의 마이너 개선사항들이 포함됩니다.

Details

  • 내부적으로 CSS Variable을 사용하여 스타일 컴포넌트(className)를 재생성하지 않도록 개선합니다.
    • Typography CSS Interpolation에 심볼을 사용해 개별 스타일 속성에 접근할 수 있도록 변경합니다.
  • 관련 테스트 케이스와 스냅샷을 업데이트합니다.

Breaking change or not (Yes/No)

No

References

없음

@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes component labels Dec 6, 2022
@sungik-choi sungik-choi self-assigned this Dec 6, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: e0f0596

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 71.18% // Head: 71.08% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (e0f0596) compared to base (cb677dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1068      +/-   ##
===========================================
- Coverage    71.18%   71.08%   -0.11%     
===========================================
  Files          208      208              
  Lines         2978     2967      -11     
  Branches       818      817       -1     
===========================================
- Hits          2120     2109      -11     
  Misses         739      739              
  Partials       119      119              
Impacted Files Coverage Δ
...components/Forms/FormHelperText/FormHelperText.tsx 100.00% <ø> (ø)
...es/bezier-react/src/components/Text/Text.styled.ts 100.00% <100.00%> (ø)
packages/bezier-react/src/components/Text/Text.tsx 100.00% <100.00%> (ø)
packages/bezier-react/src/foundation/Typography.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link
Contributor

@yangwooseong yangwooseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description 에서 Related Issues 에 있는 z-stack 이슈는 혹시 오타인가요? 제가 오해한게 아니라면 관련이 없어 보여서요!

@sungik-choi
Copy link
Contributor Author

PR description 에서 Related Issues 에 있는 z-stack 이슈는 혹시 오타인가요? 제가 오해한게 아니라면 관련이 없어 보여서요!

복붙 이슈네요... 😅

@sungik-choi sungik-choi merged commit 65cdafa into channel-io:next-v1 Dec 21, 2022
@sungik-choi sungik-choi deleted the enhance/text branch December 21, 2022 05:23
sungik-choi added a commit to sungik-choi/bezier-react that referenced this pull request Dec 26, 2022
sungik-choi added a commit that referenced this pull request Dec 27, 2022
* Revert "Enhance the `Text` component (#1068)"

This reverts commit 65cdafa.

* chore(changeset): add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better refactoring Issue or PR related to refactoring with no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants