Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Nov 25, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Fixes #1042, Fixes #773

Summary

getRootElement() 함수의 반환값을 특정 id를 가진 엘리먼트(e.g. main)에서 document.body 엘리먼트로 변경합니다.

Details

Breaking change or not (Yes/No)

Yes

References

없음

@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better fix PR related to bug fix labels Nov 25, 2022
@sungik-choi sungik-choi self-assigned this Nov 25, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: c11a611

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 71.20% // Head: 71.19% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c11a611) compared to base (74ac5ed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1048      +/-   ##
===========================================
- Coverage    71.20%   71.19%   -0.01%     
===========================================
  Files          208      208              
  Lines         2980     2979       -1     
  Branches       823      822       -1     
===========================================
- Hits          2122     2121       -1     
  Misses         739      739              
  Partials       119      119              
Impacted Files Coverage Δ
packages/bezier-react/src/utils/domUtils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link
Contributor

@Dogdriip Dogdriip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 body가 없는 경우도 있을지 찾아보았는데 그런 상황은 거의 없을 것 같네요.

@quino0627 quino0627 requested a review from dinohan November 25, 2022 10:50
@sungik-choi sungik-choi merged commit fe9640b into channel-io:next-v1 Nov 30, 2022
@sungik-choi sungik-choi deleted the fix/get-root-element branch November 30, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better fix PR related to bug fix

Projects

None yet

4 participants