-
Notifications
You must be signed in to change notification settings - Fork 52
Change return value of getRootElement() from element with specific id to document.body element
#1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change return value of getRootElement() from element with specific id to document.body element
#1048
Conversation
🦋 Changeset detectedLatest commit: c11a611 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 71.20% // Head: 71.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1048 +/- ##
===========================================
- Coverage 71.20% 71.19% -0.01%
===========================================
Files 208 208
Lines 2980 2979 -1
Branches 823 822 -1
===========================================
- Hits 2122 2121 -1
Misses 739 739
Partials 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
Dogdriip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 body가 없는 경우도 있을지 찾아보았는데 그런 상황은 거의 없을 것 같네요.
Self Checklist
CODEOWNERSfile.Related Issue
Fixes #1042, Fixes #773
Summary
getRootElement()함수의 반환값을 특정 id를 가진 엘리먼트(e.g. main)에서document.body엘리먼트로 변경합니다.Details
getRootElement()from element with specific id todocument.bodyelement #1042 를 참고해주세요.Breaking change or not (Yes/No)
Yes
References
없음