Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Nov 15, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Fixes #996

Summary

Stackalign prop의 기본값을 start 에서 stretch 로 변경합니다.

Details

#996 참고. CSS Flexible Box Layout Module Level 1의 스펙에 따르면, align-items 속성의 기본값은 stretch 입니다. 라이브러리를 사용하는 엔지니어들이 의도한대로 컴포넌트가 동작할 수 있도록, 기본값을 표준에 맞게 변경했습니다.

Breaking change or not (Yes/No)

Yes

애플리케이션에서 대부분은 stretch 로 설정되어있으나, 기본값을 사용하고 있는 사용처가 몇 있어 마이그레이션이 필요합니다.

References

@sungik-choi sungik-choi added enhancement Issues or PR related to making existing features better component labels Nov 15, 2022
@sungik-choi sungik-choi self-assigned this Nov 15, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: b05422b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 71.15% // Head: 71.15% // No change to project coverage 👍

Coverage data is based on head (b05422b) compared to base (80f3358).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1030   +/-   ##
========================================
  Coverage    71.15%   71.15%           
========================================
  Files          208      208           
  Lines         2961     2961           
  Branches       821      821           
========================================
  Hits          2107     2107           
  Misses         736      736           
  Partials       118      118           
Impacted Files Coverage Δ
.../bezier-react/src/components/Stack/Stack/Stack.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi merged commit f407fca into channel-io:next-v1 Nov 23, 2022
@sungik-choi sungik-choi deleted the enhance/stack branch November 23, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Issues or PR related to making existing features better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply default value of CSS Flex align-items property to Stack component

3 participants