-
Notifications
You must be signed in to change notification settings - Fork 52
Update the font-size of TextField
#1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the font-size of TextField
#1028
Conversation
🦋 Changeset detectedLatest commit: 971c413 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 71.15% // Head: 71.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1028 +/- ##
===========================================
- Coverage 71.15% 71.07% -0.09%
===========================================
Files 208 208
Lines 2961 2966 +5
Branches 821 822 +1
===========================================
+ Hits 2107 2108 +1
- Misses 736 739 +3
- Partials 118 119 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
Dogdriip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size prop에 대한 렌더링 테스트를 추가해야 할 것 같습니다. (Codecov 넘기실 거라면 다른 부분은 모두 괜찮습니다!)
스토리북 UI 테스트로 대체 가능한 부분이라고 생각해서 별도로 추가하진 않으려고 합니다. |
Self Checklist
CODEOWNERSfile.Related Issue
Fixes #820
Summary
베지어 디자인 시스템 시안과 동일하게
TextField컴포넌트의 텍스트 스타일을 적용합니다.Details
input엘리먼트의 불필요한sizeattribute를 제거합니다. (MDN)Breaking change or not (Yes/No)
No
References
없음