Skip to content

Conversation

@sungik-choi
Copy link
Contributor

@sungik-choi sungik-choi commented Nov 15, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

Fixes #820

Summary

베지어 디자인 시스템 시안과 동일하게 TextField 컴포넌트의 텍스트 스타일을 적용합니다.

Details

  • input 엘리먼트의 불필요한 size attribute를 제거합니다. (MDN)
  • 나머지는 스토리북을 참고 부탁드립니다.

Breaking change or not (Yes/No)

No

References

없음

@sungik-choi sungik-choi added component design update Issue or PR that Up-to-date specifications for design system updates labels Nov 15, 2022
@sungik-choi sungik-choi self-assigned this Nov 15, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: 971c413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 71.15% // Head: 71.07% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (971c413) compared to base (80f3358).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           next-v1    #1028      +/-   ##
===========================================
- Coverage    71.15%   71.07%   -0.09%     
===========================================
  Files          208      208              
  Lines         2961     2966       +5     
  Branches       821      822       +1     
===========================================
+ Hits          2107     2108       +1     
- Misses         736      739       +3     
- Partials       118      119       +1     
Impacted Files Coverage Δ
...rc/components/Forms/Inputs/TextField/TextField.tsx 53.70% <ø> (ø)
...ponents/Forms/Inputs/TextField/TextField.styled.ts 64.51% <20.00%> (-8.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

Copy link
Contributor

@Dogdriip Dogdriip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size prop에 대한 렌더링 테스트를 추가해야 할 것 같습니다. (Codecov 넘기실 거라면 다른 부분은 모두 괜찮습니다!)

@sungik-choi
Copy link
Contributor Author

size prop에 대한 렌더링 테스트를 추가해야 할 것 같습니다. (Codecov 넘기실 거라면 다른 부분은 모두 괜찮습니다!)

스토리북 UI 테스트로 대체 가능한 부분이라고 생각해서 별도로 추가하진 않으려고 합니다.

@sungik-choi sungik-choi merged commit d6b2852 into channel-io:next-v1 Nov 23, 2022
@sungik-choi sungik-choi deleted the update/text-field-font-size branch November 23, 2022 04:17
sungik-choi added a commit to sungik-choi/bezier-react that referenced this pull request Dec 3, 2022
sungik-choi added a commit that referenced this pull request Dec 3, 2022
…ut` element (#1052)

* revert(text-field): revert removing input's size attribute

part of #1028

* chore(changeset): add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design update Issue or PR that Up-to-date specifications for design system updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the font-size of TextField

3 participants