Skip to content

Conversation

@Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Nov 11, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • [Component] I wrote a unit test about the implementation.
  • [Component] I wrote a storybook document about the implementation.
  • [Component] I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox
  • [New Component] I added my username to the correct directory in the CODEOWNERS file.

Related Issue

None.

Summary

  • Semantic color 업데이트에 따라 이를 bezier-react에 반영합니다.
    • bg-black-darkest → black40(white40)에서 black60(white60)으로 변경
    • bg-black-darker → black40(white40)으로 신설
    • 이에 따라 bg-black-darkest로 적용되었던 컬러들은 bg-black-darker로 변경필요.

Details

  • 생략

Breaking change or not (Yes/No)

Yes.

  • bg-black-darkest is now Palette.black_60 on LightTheme, Palette.white_60 on DarkTheme.

References

@Dogdriip Dogdriip added the design update Issue or PR that Up-to-date specifications for design system updates label Nov 11, 2022
@Dogdriip Dogdriip self-assigned this Nov 11, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

🦋 Changeset detected

Latest commit: ec1171d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Minor
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 71.15% // Head: 71.15% // No change to project coverage 👍

Coverage data is based on head (ec1171d) compared to base (c88a427).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1006   +/-   ##
========================================
  Coverage    71.15%   71.15%           
========================================
  Files          208      208           
  Lines         2961     2961           
  Branches       821      821           
========================================
  Hits          2107     2107           
  Misses         736      736           
  Partials       118      118           
Impacted Files Coverage Δ
...ezier-react/src/components/Button/Button.styled.ts 92.64% <ø> (ø)
...gBadge/TagBadgeCommon/constants/TagBadgeVariant.ts 100.00% <ø> (ø)
...t/src/foundation/Colors/Theme/presets/DarkTheme.ts 100.00% <ø> (ø)
.../src/foundation/Colors/Theme/presets/LightTheme.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

Chromatic Report

🚀 Congratulations! Your build was successful!

@Dogdriip Dogdriip requested a review from dinohan November 11, 2022 06:58
@sungik-choi sungik-choi added the feat:foundation Issue of PR related to a new foundation label Nov 11, 2022
@sungik-choi
Copy link
Contributor

이에 따라 bg-black-darkest로 적용되었던 컬러들은 bg-black-darker로 변경필요.

bg-black-darkest 사용처 Button, Tag, Badge 에서 bg-black-darker 로 변경해야하지 않을까요?

@Dogdriip
Copy link
Contributor Author

이에 따라 bg-black-darkest로 적용되었던 컬러들은 bg-black-darker로 변경필요.

bg-black-darkest 사용처 Button, Tag, Badge 에서 bg-black-darker 로 변경해야하지 않을까요?

549a158 에서 bezier 내의 사용처는 모두 변경한 것 같은데, 혹시 더 변경해야 할 곳이 있을까요?

@sungik-choi
Copy link
Contributor

549a158 에서 bezier 내의 사용처는 모두 변경한 것 같은데, 혹시 더 변경해야 할 곳이 있을까요?

제대로 확인을 안했네요. 다 잘 변경된 거 같습니다. 어플리케이션에서 변경도 해줘야겠네요..

@Dogdriip Dogdriip merged commit d90c27a into channel-io:next-v1 Nov 13, 2022
@Dogdriip Dogdriip deleted the fix/bg-black-darker branch November 13, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design update Issue or PR that Up-to-date specifications for design system updates feat:foundation Issue of PR related to a new foundation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants