-
Notifications
You must be signed in to change notification settings - Fork 52
Add bg-black-darker semantic color, update bg-black-darkest to black60(white60)
#1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ec1171d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportBase: 71.15% // Head: 71.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## next-v1 #1006 +/- ##
========================================
Coverage 71.15% 71.15%
========================================
Files 208 208
Lines 2961 2961
Branches 821 821
========================================
Hits 2107 2107
Misses 736 736
Partials 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Chromatic Report🚀 Congratulations! Your build was successful! |
|
549a158 에서 bezier 내의 사용처는 모두 변경한 것 같은데, 혹시 더 변경해야 할 곳이 있을까요? |
제대로 확인을 안했네요. 다 잘 변경된 거 같습니다. 어플리케이션에서 변경도 해줘야겠네요.. |
Self Checklist
[Component] I wrote a unit test about the implementation.[Component] I wrote a storybook document about the implementation.[Component] I tested the implementation in various browsers.[New Component] I added my username to the correct directory in theCODEOWNERSfile.Related Issue
None.
Summary
bezier-react에 반영합니다.bg-black-darkest→ black40(white40)에서 black60(white60)으로 변경bg-black-darker→ black40(white40)으로 신설bg-black-darkest로 적용되었던 컬러들은bg-black-darker로 변경필요.Details
Breaking change or not (Yes/No)
Yes.
bg-black-darkestis nowPalette.black_60onLightTheme,Palette.white_60onDarkTheme.References