Skip to content

Conversation

@aooen
Copy link
Contributor

@aooen aooen commented Nov 10, 2022

Self Checklist

  • I wrote a PR title in English.
  • I added an appropriate label to the PR.
  • I wrote a commit message in English.
  • I wrote a commit message according to the Conventional Commits specification.
  • I added the appropriate changeset for the changes.
  • I wrote a unit test about the implementation.
  • I wrote a storybook document about the implementation.
  • I tested the implementation in various browsers.
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Details

  • TagBadgeSize.XS font size is changed from Size12 to Size11

Breaking change or not (No)

References

@aooen aooen added the fix PR related to bug fix label Nov 10, 2022
@aooen aooen self-assigned this Nov 10, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022

🦋 Changeset detected

Latest commit: da7d043

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aooen aooen requested a review from sungik-choi November 10, 2022 06:13
@aooen aooen changed the title Quick fix/change tag badge size xs fix(tagbadge): make xs tagbadge more smaller Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 71.15% // Head: 71.15% // No change to project coverage 👍

Coverage data is based on head (da7d043) compared to base (73a95a9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           next-v1    #1001   +/-   ##
========================================
  Coverage    71.15%   71.15%           
========================================
  Files          208      208           
  Lines         2961     2961           
  Branches       821      821           
========================================
  Hits          2107     2107           
  Misses         736      736           
  Partials       118      118           
Impacted Files Coverage Δ
...ct/src/components/TagBadge/TagBadgeCommon/utils.ts 80.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Chromatic Report

🚀 Congratulations! Your build was successful!

@sungik-choi sungik-choi added component design update Issue or PR that Up-to-date specifications for design system updates and removed fix PR related to bug fix labels Nov 10, 2022
Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix 보다 design update 가 적절한 거 같아 라벨 변경했습니다.

@aooen
Copy link
Contributor Author

aooen commented Nov 10, 2022

fix 보다 design update 가 적절한 거 같아 라벨 변경했습니다.

아 이런 라벨이 있었네요

@aooen aooen requested a review from quino0627 November 10, 2022 07:55
@aooen aooen merged commit ca1c614 into channel-io:next-v1 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design update Issue or PR that Up-to-date specifications for design system updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants