Removed fs-extra dependency
#481
Conversation
|
src/index.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import * as core from "@actions/core"; | |||
| import fs from "fs-extra"; | |||
| import fs from "node:fs"; | |||
There was a problem hiding this comment.
Synchronous / Blocking FS calls should always be avoided, you can import the promises object which includes async fs calls and use it directly:
| import fs from "node:fs"; | |
| import {promises as fs} from "node:fs"; |
There was a problem hiding this comment.
ye, right - this action is really only executed alone though and its flow is really linear anyway, so using sync variants felt just simpler. I switched back everything to fs/promises now though
* upstream/main: (28 commits) Version Packages (changesets#480) Fixed missed `__dirname` reference (changesets#496) Switch to bundling with Rollup (changesets#495) Migrate to ESM (changesets#484) Fixed situations in which `cwd` was specified as a relative path and used with (default) `commitMode: git-cli` (changesets#486) Add LICENSE file (changesets#491) Fix PRs sometimes not getting reopened with `commitMode: github-api` (changesets#488) Removed `fs-extra` dependency (changesets#481) Setup Git user in `release-pr` workflow (changesets#493) Use proper ndoe version in `release-pr` workflow (changesets#492) Add `release-pr` workflow (changesets#490) Migrate to Vitest (changesets#483) Switch to `esbuild` for bundling (changesets#479) Import only for `semver/functions/lt` (changesets#482) Avoid hitting a deprecation warning when encountering errors from `@octokit/request-error` (changesets#461) Run typecheck on CI (changesets#478) Updated `@actions/*` and `@octokit/*` dependencies (changesets#477) Bump @babel/runtime from 7.21.5 to 7.27.1 (changesets#464) Version Packages (changesets#476) Make git add work consistently with subdirectories (changesets#473) ...
No description provided.