add-date-filter-to-pending.php #6526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicoDucou
reviewed
Aug 1, 2025
NicoDucou
reviewed
Aug 1, 2025
main/inc/ajax/model.ajax.php
Outdated
| @@ -6,6 +6,10 @@ | |||
|
|
|||
| require_once __DIR__.'/../global.inc.php'; | |||
|
|
|||
| // --- FILTRES DATE --- | |||
There was a problem hiding this comment.
Comments should be in english :
date filters
NicoDucou
reviewed
Aug 1, 2025
NicoDucou
reviewed
Aug 1, 2025
main/inc/ajax/model.ajax.php
Outdated
Comment on lines
652
to
663
| if ((false === api_is_teacher()) && (false === api_is_session_admin())) { | ||
| exit; | ||
| } | ||
|
|
||
| $courseId = $_REQUEST['course_id'] ?? 0; | ||
| $exerciseId = $_REQUEST['exercise_id'] ?? 0; | ||
| $status = $_REQUEST['status'] ?? 0; | ||
| $questionType = $_REQUEST['questionType'] ?? 0; | ||
| $showAttemptsInSessions = $_REQUEST['showAttemptsInSessions'] ? true : false; | ||
| if (isset($_GET['filter_by_user']) && !empty($_GET['filter_by_user'])) { | ||
| $filter_user = (int) $_GET['filter_by_user']; | ||
| if (empty($whereCondition)) { |
There was a problem hiding this comment.
There is an indentation problem.
There should be 8 spaces before each line in the case.
NicoDucou
reviewed
Aug 1, 2025
|
The code works but there are a few things to be reviewed to be able to accept this PR. |
|
@yverhenne good work, the functionnality works fine, but I let you review those comments before reviewing this PR again. Best regard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows filtering by start and end date, the attempts waiting for correction on the pending.php page