Fix for the array inline segment assert. #6294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is there a code change? I only see the UT. |
Contributor
Author
|
huh - should have added sources as well. thanks |
This assert is happening due to false positive. The array's head segment is not allocated as inlined - but it was allocated on the page boundary. That makes this segement to just aligned with the array and we got the assert fired for wrong reason. We don't need to check the assert for the source array to be not inlined as in the above 'else' condition we allocated the dest segment ourselve in the same function. So I removed the part where we check the current array is not inlined.
Contributor
Author
|
Fixes #6277 |
pleath
approved these changes
Sep 25, 2019
zenparsing
approved these changes
Sep 26, 2019
Contributor
Author
|
The fix is merged - but not sure why this PR is not closed. |
akroshg
added a commit
to akroshg/ChakraCore
that referenced
this pull request
Oct 4, 2019
…sert. Merge pull request chakra-core#6294 from akroshg:fix_6277 This assert is happening due to false positive. The array's head segment is not allocated as inlined - but it was allocated on the page boundary. That makes this segement to just aligned with the array and we got the assert fired for wrong reason. We don't need to check the assert for the source array to be not inlined as in the above 'else' condition we allocated the dest segment ourselve in the same function. So I removed the part where we check the current array is not inlined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert is happening due to false positive. The array's head segment is not allocated as inlined - but it was allocated on the page boundary.
That makes this segement to just aligned with the array and we got the assert fired for wrong reason.
We don't need to check the assert for the source array to be not inlined as in the above 'else' condition we allocated the dest segment ourselve in the same function.
So I removed the part where we check the current array is not inlined.