Skip to content

Add Soft Actor-Critic agent #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Aug 15, 2019
Merged

Add Soft Actor-Critic agent #457

merged 55 commits into from
Aug 15, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented May 12, 2019

Merge #453 before this PR.

  • SoftActorCritic agent is added. It implements the variant of SAC described in https://arxiv.org/abs/1812.05905.
  • SquashedGaussianDistribution is added.
  • arctanh function is added.
  • examples/mujoco/soft_actor_critic/train_soft_actor_critic.py is added to reproduce the results reported by the paper.

As you can see from the tables in README, our results are competitive with theirs.
https://github.com/muupan/chainerrl/tree/soft-actor-critic/examples/mujoco/reproduction/soft_actor_critic

TODO

  • add tests of SoftActorCritic
  • add tests of SquashedGaussianDistribution
  • fix error with chainer v4

@muupan
Copy link
Member Author

muupan commented Jul 3, 2019

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit d9d264b:

1 similar comment
@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit d9d264b:

@muupan muupan changed the title [WIP] Add Soft Actor-Critic agent Add Soft Actor-Critic agent Jul 4, 2019
@muupan muupan requested a review from ummavi July 16, 2019 09:58
Copy link
Member

@ummavi ummavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muupan muupan merged commit 508ed07 into chainer:master Aug 15, 2019
@muupan muupan deleted the soft-actor-critic branch August 15, 2019 10:57
@muupan muupan added this to the v0.8 milestone Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants