Skip to content

Enables batch DDPG agents to be trained. #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 12, 2019

Conversation

prabhatnagarajan
Copy link
Contributor

No description provided.

@prabhatnagarajan prabhatnagarajan changed the title [WIP] Enables batch DDPG agents to be trained. Enables batch DDPG agents to be trained. Mar 26, 2019
@prabhatnagarajan
Copy link
Contributor Author

This PR changes two Q-functions: FCBNLateActionSAQFunction and FCLateActionSAQFunction. A simple search in the ChainerRL repository:

https://github.com/chainer/chainerrl/search?q=FCBNLateActionSAQFunction&unscoped_q=FCBNLateActionSAQFunction

https://github.com/chainer/chainerrl/search?q=FCLateActionSAQFunction&unscoped_q=FCLateActionSAQFunction

shows that the DDPG example is the only place these are used. Furthermore, looking at the __init__ functions for those networks, it appears that neither of them need recurrence. Since

class MLP(chainer.Chain):

and

class MLPBN(chainer.Chain):

are not recurrent.

@prabhatnagarajan
Copy link
Contributor Author

Swimmer-v2-BatchDDPGBN
Swimmer-v2-DDPGBN

@prabhatnagarajan prabhatnagarajan requested a review from muupan April 6, 2019 12:12
@prabhatnagarajan prabhatnagarajan requested a review from muupan April 12, 2019 14:46
Copy link
Member

@muupan muupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@muupan muupan merged commit b8c72c9 into chainer:master Apr 12, 2019
@prabhatnagarajan prabhatnagarajan deleted the batch_ddpg branch May 28, 2019 14:53
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants