Skip to content

Add tests of IQN examples #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Add tests of IQN examples #405

merged 1 commit into from
Feb 27, 2019

Conversation

muupan
Copy link
Member

@muupan muupan commented Feb 26, 2019 •
edited
Loading

Tests of IQN examples were missing, so this PR adds them to test_examples.sh. Updated the examples to make them work with latest API.

@muupan muupan added this to the v0.6 milestone Feb 26, 2019
@muupan
Copy link
Member Author

muupan commented Feb 26, 2019

I confirmed that both ./test_examples.sh -1 and ./test_examples.sh 0 work.

prabhatnagarajan
prabhatnagarajan approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@muupan muupan added the test label Feb 26, 2019
@muupan muupan merged commit 94a0d41 into chainer:master Feb 27, 2019
@muupan muupan deleted the test-iqn-example branch February 27, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @prabhatnagarajan