Skip to content

Use chainer.dataset.concat_examples in batch_states #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2018
Merged

Use chainer.dataset.concat_examples in batch_states #366

merged 2 commits into from
Dec 14, 2018

Conversation

muupan
Copy link
Member

@muupan muupan commented Dec 10, 2018

This change enables the default batch_states function to handle tuple-shaped observations.

I'm running the whole tests.

@muupan muupan mentioned this pull request Dec 13, 2018
Merged
4 tasks
@toslunar toslunar self-requested a review December 14, 2018 01:45
toslunar
toslunar approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar added this to the v0.6 milestone Dec 14, 2018
@toslunar toslunar merged commit 4b89c47 into chainer:master Dec 14, 2018
@muupan muupan modified the milestone: v0.6 Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar