Skip to content

Align act and act_and_train's signature to the Agent interface #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

lyx-x
Copy link
Contributor

@lyx-x lyx-x commented Feb 11, 2018

#229 Change function signatures in agents implementing the Agent interface so the argument name become consistent.

Tested with pytest -m 'not slow' and ./test_examples.sh 0

@muupan muupan self-assigned this Feb 13, 2018
@muupan
Copy link
Member

muupan commented Feb 13, 2018

Looks good. Thank you for the PR!

@muupan muupan merged commit cb47303 into chainer:master Feb 13, 2018
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants