Skip to content

Fix PCL tests #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2017
Merged

Fix PCL tests #211

merged 1 commit into from
Dec 28, 2017

Conversation

muupan
Copy link
Member

@muupan muupan commented Dec 28, 2017

Resolves #159

It seems setting a minimum probability is harmful here.

After this PR, test_pcl.py succeeded 10 times in a row.

$ for i in `seq 10`; do nosetests -x tests/agents_tests/test_pcl.py; done
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 215.050s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 296.631s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 167.221s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 267.790s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 281.979s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 195.559s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 204.496s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 279.983s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 181.846s

OK
................................................................................................
----------------------------------------------------------------------
Ran 96 tests in 242.569s

OK

@toslunar
Copy link
Member

Great!

toslunar
toslunar reviewed Dec 28, 2017
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit c49310e into chainer:master Dec 28, 2017
@muupan muupan added the test label Jul 23, 2018
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar left review comments

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@muupan @toslunar