Remove use of deprecated c/r Result.Requeue

[erikgb]

The field Result.Requeue is deprecated in controller-runtime 0.21.0, and I don't know why we are using it at all - since the Godoc of Result.RequeueAfter states:

// RequeueAfter if greater than 0, tells the Controller to requeue the reconcile key after the Duration.
// Implies that Requeue is true, there is no need to set Requeue to true at the same time as RequeueAfter.

Blocks #640.

[wallrj]

Thanks @erikgb

I see that this was flagged by the verify checks in #640 and that this will allow us to upgrade to the latest version of controller-runtime. Good.

• https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_approver-policy/640/pull-cert-manager-approver-policy-verify/1928371722667429888

pkg/internal/controllers/certificaterequestpolicies.go:198:6: SA1019: response.Requeue is deprecated: Use `RequeueAfter` instead. (staticcheck)
		if response.Requeue || response.RequeueAfter > 0 {
		   ^
pkg/internal/controllers/certificaterequestpolicies.go:199:8: SA1019: result.Requeue is deprecated: Use `RequeueAfter` instead. (staticcheck)
			if !result.Requeue || result.RequeueAfter > response.RequeueAfter {
			    ^
pkg/internal/controllers/certificaterequestpolicies.go:202:4: SA1019: result.Requeue is deprecated: Use `RequeueAfter` instead. (staticcheck)
			result.Requeue = true
			^
3 issues:

FTR: I agree with some of the comments in kubernetes-sigs/controller-runtime#3107. I do think it was a useful option to be able to requeue and make use of the builtin backoff timer...but I'm not sure if that how it was intended to be used here.

• kubernetes-sigs/controller-runtime#3107

/approve
/lgtm

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment