chore(share/shwap/p2p/shrex): Add shrex server successful payload served metric #4658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
reviewed
Oct 27, 2025
walldiss
reviewed
Oct 31, 2025
walldiss
reviewed
Oct 31, 2025
…al bytes written (including status + partial resp); attribute `incomplete` if unsuccessful response for better filtering
… can derive this from requestDuration count
renaynay
force-pushed
the
rene/shrex-metrics
branch
from
997f4e2 to
8e28e17
Compare
vgonkivs
previously approved these changes
Nov 3, 2025
walldiss
reviewed
Nov 3, 2025
share/shwap/p2p/shrex/server.go
Outdated
| if err != nil { | ||
| log.Errorw("sending response status", "err", err) | ||
| return statusSendStatusErr | ||
| return statusSendStatusErr, 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metric will be able to help us track BN shrex serving throughput by request type (
nd,eds, and soon will be sample).In grafana, we can visualise serving throughput in MB/s with a panel via the following query:
shrex-ndshrex-eds