Fix bug when run command celery
#569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidpele
reviewed
Jun 2, 2019
| @@ -17,7 +17,6 @@ class Command(CeleryCommand): | |||
| preload_options = base.preload_options if base.preload_options else [] | |||
| else: | |||
| preload_options = [] | |||
| preload_options = base.preload_options if base.preload_options else [] | |||
There was a problem hiding this comment.
It looks like this and the if/else block could be replace with just:
preload_options = getattr(base, 'preload_options', []) or []
There was a problem hiding this comment.
I fixed it. Thanks, @liquidpele :).
|
@auvipy , it's failed looked like some others. I think it should be fixed somewhere but this PR. |
|
'CeleryCommand' object has no attribute 'preload_options' |
|
flake8 tests are failing now. |
liquidpele
reviewed
Jun 5, 2019
| def _validate_thread_sharing(self): | ||
| if (not self.allow_thread_sharing and | ||
| self._thread_ident != _get_ident()): | ||
| if not self.validate_thread(): |
There was a problem hiding this comment.
I think you are missing the underscore for the method name you added?
lpthong90
commented
Jun 6, 2019
| raise DatabaseError( | ||
| DB_SHARED_THREAD % ( | ||
| self.alias, self._thread_ident, _get_ident()), | ||
| ) | ||
|
|
||
| BaseDatabaseWrapper.__init__ = _init | ||
| BaseDatabaseWrapper.validate_thread = _validate_thread |
There was a problem hiding this comment.
@liquidpele , it doesn't have underscore here.
There was a problem hiding this comment.
Oh, I see. Didn't expand to look at the whole file. Thx.
liquidpele
approved these changes
Jun 6, 2019
auvipy
approved these changes
Jun 6, 2019
maxmalysh
pushed a commit
to maxmalysh/django-celery
that referenced
this pull request
Jul 29, 2019
* fix bug when run command `celery` * refactor get preload_options from base * fix failed by flask8 * fix tests * remove redundant * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug when run
python manage celeryrelated to attributepreload_optionsnot existed inCeleryCommand.