-
Couldn't load subscription status.
- Fork 118
Open
Description
Because of this line:
php-trello-api/lib/Trello/Model/Checklist.php
Line 245 in b1205d9
| $this->data['checkItems'][$key]['state'] = in_array($item['state'], array(true, 'complete', 'true')); |
$this->data['checkItems'][$key]['state'] = in_array($item['state'], array(true, 'complete', 'true'));
Should be:
$this->data['checkItems'][$key]['state'] = in_array($item['state'], array(true, 'complete', 'true'), true);
The problem is that both 'incomplete' == true and 'complete' == true evaluate to true. The strict mode is required (in_array, third parameter). To me it seems even unneeded to have this kind of in_array check. The values are just 'incomplete' and 'complete', right? Can't we trust on that?