Skip to content

Conversation

@qualiaMachine
Copy link
Collaborator

The key change here is that I require learners to download Python 3.11.9, which is compatible with Tensorflow and Keras. Newer versions of Python may run into some issues. There are a few other minor changes to the setup — let me know if you want this broken into multiple pull request. I'll summarize below:

  1. Provide overview of all setup steps at the top to help frame the full setup
  2. Require python version 3.11.9
  3. Add instructions for checking python version before/while installing packages and after Jupyter lab is launched to confirm everything worked
  4. Explicitly tell learners to create a data folder, and update episodes with data path, when needed
  5. Recommend Git Bash over Anaconda Prompt for those on Windows machines. Tends to have fewer Windows quirks.
  6. Emphasize/bold activating virtual environment before launching Jupyter Lab
  7. Call the virtual environment "venv", as this is standard practice. Add comments clarifying why we type "venv" twice when creating the virtual environment.
  8. Add note about Colab, and how learners will have to upload their data to MyDrive and mount their google drive (code shown)

@github-actions
Copy link

github-actions bot commented May 15, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-lab/deep-learning-intro/compare/md-outputs..md-outputs-PR-587

The following changes were observed in the rendered markdown documents:

 3-monitor-the-model.md    |   2 +-
 4-advanced-layer-types.md |   2 +-
 5-transfer-learning.md    |   2 +-
 md5sum.txt                |   8 +-
 setup.md                  | 182 +++++++++++++++++++++++++++++++++++-----------
 5 files changed, 147 insertions(+), 49 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-05-18 20:17:35 +0000

github-actions bot pushed a commit that referenced this pull request May 15, 2025
github-actions bot pushed a commit that referenced this pull request May 18, 2025
github-actions bot pushed a commit that referenced this pull request May 18, 2025
github-actions bot pushed a commit that referenced this pull request May 18, 2025
github-actions bot pushed a commit that referenced this pull request May 18, 2025
Copy link
Collaborator

@carschno carschno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, apologies for the late review.
I have left a few suggestions, mostly about using .venv instead of venv.

```shell
py -m venv dl_workshop
# Use python3 or py instead if one of them points to 3.11.9.
python -m venv venv # 1st "venv" is commmand, 2nd venv is name of the virtual environment / folder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guide linked above uses .venv as environment folder, which has become best practice. The downside is (on purpose) that the folder is invisible by default, but I think I would prefer sticking with the instructions to avoid confusion.

Suggested change
python -m venv venv # 1st "venv" is commmand, 2nd venv is name of the virtual environment / folder
python -m venv .venv

```shell
python3 -m venv dl_workshop
python --version
py --version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line has potential for confusion. Where does a py binary come from? Is it likely to occur when following the instructions above?

Suggested change
py --version


Open a terminal and run the following commands.

1. Create a [virtual environment](https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/#create-and-use-virtual-environments) called `venv` using the "venv" command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create a [virtual environment](https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/#create-and-use-virtual-environments) called `venv` using the "venv" command:
1. Create a [virtual environment](https://packaging.python.org/en/latest/guides/installing-using-pip-and-virtual-environments/#create-and-use-virtual-environments) using the "venv" command:

Comment on lines +85 to +93
If you run the `ls` command from `~/Desktop/dl_workshop`, you should see a new `venv` folder inside it

```shell
ls
```

```output
venv/
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with my suggestions above, and for conciseness:

Suggested change
If you run the `ls` command from `~/Desktop/dl_workshop`, you should see a new `venv` folder inside it
```shell
ls
```
```output
venv/
```
If you run the `ls` command from `~/Desktop/dl_workshop`, you should see a new `.venv` folder inside it
```shell
ls -a -d .venv
.venv


```shell
source dl_workshop/bin/activate
source venv/bin/activate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source venv/bin/activate
source .venv/bin/activate


```shell
dl_workshop\Scripts\activate
venv\Scripts\activate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
venv\Scripts\activate
.venv\Scripts\activate

If you're using Git Bash on Windows, you need to add the source command first.

```shell
source venv/Scripts/activate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
source venv/Scripts/activate
source .venv/Scripts/activate

Remember that you need to activate your environment every time you restart your terminal!
**Note**: Remember that you need to activate your environment every time you restart your terminal, and before you launch Jupyter Lab!

3. After activating the enviornment, upgrade pip. This is a good practice to follow when you first initialize your virtual environment (beforing installing additional packages). [Pip](https://pip.pypa.io/en/stable/) is the package management system built into Python.Pip should be available in your system once you installed Python successfully.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Suggested change
3. After activating the enviornment, upgrade pip. This is a good practice to follow when you first initialize your virtual environment (beforing installing additional packages). [Pip](https://pip.pypa.io/en/stable/) is the package management system built into Python.Pip should be available in your system once you installed Python successfully.
3. After activating the environment, upgrade pip. This is a good practice to follow when you first initialize your virtual environment (beforing installing additional packages). [Pip](https://pip.pypa.io/en/stable/) is the package management system built into Python.Pip should be available in your system once you installed Python successfully.


4. Install the required packages:

Follow the OS-specific instructions below. NOte that It may take 10-20 minutes to install everything.

This comment was marked as duplicate.

Copy link
Collaborator

@ashwinvis ashwinvis Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Follow the OS-specific instructions below. NOte that It may take 10-20 minutes to install everything.
Follow the OS-specific instructions below. Note that it may take 10-20 minutes to install everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants