- 
                Notifications
    You must be signed in to change notification settings 
- Fork 214
Add tests for NMT base and NMT master #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
 Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   67.90%   68.74%   +0.83%     
==========================================
  Files          26       26              
  Lines        3116     3116              
  Branches      527      527              
==========================================
+ Hits         2116     2142      +26     
+ Misses        858      837      -21     
+ Partials      142      137       -5      | 
| More yak shave for #500. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is impressive. Thank you very much for your diligence. I could never have come up with all these test cases...
| FTR, I will follow up with a PR for hardening the NMT slave tests. | 
No description provided.