Skip to content

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Jun 3, 2025

Issue

The admin role should be removed and not available anymore to be used as an extra-user-role, as different roles were already introduced by #881 and will also be introduced by #921. Those new roles should replace the currently existing admin role.

The postgres user is not used for anything (as we have the operator user as the superuser).

Solution

Remove the admin role and the postgres user creation.

TODO: lib/charms/postgresql_k8s/v0/postgresql.py will be moved to lib/charms/postgresql_k8s/v1/postgresql.py in a next PR.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.23%. Comparing base (03b7e54) to head (24605d9).
Report is 1 commits behind head on 16/edge.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge     #931      +/-   ##
===========================================
+ Coverage    70.22%   70.23%   +0.01%     
===========================================
  Files           16       16              
  Lines         3725     3723       -2     
  Branches       542      541       -1     
===========================================
- Hits          2616     2615       -1     
  Misses         974      974              
+ Partials       135      134       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

marceloneppel and others added 7 commits June 4, 2025 09:41
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel changed the base branch from feature/16_predefined_instance_roles to feature/16_predefined_dba_role June 4, 2025 15:18
marceloneppel and others added 6 commits June 4, 2025 12:20
…oles' into feature/16_predefined_dba_role

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…oles' into feature/16_predefined_dba_role

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel added the enhancement New feature, UI change, or workload upgrade label Jun 5, 2025
@marceloneppel marceloneppel changed the title Remove admin and postgres roles [DPE-7499] Remove admin and postgres roles Jun 5, 2025
@marceloneppel marceloneppel marked this pull request as ready for review June 5, 2025 14:49
…into feature/16_predefined_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞
Q: do we need to change something on pgbouncer after merging this?

@marceloneppel
Copy link
Member Author

🤞 Q: do we need to change something on pgbouncer after merging this?

We'll need to update the library on PgBouncer through canonical/pgbouncer-operator#549 after merging #921, so that it properly creates the roles when a client app requests a new database to be created by PgBouncer.

…into feature/16_predefined_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Base automatically changed from feature/16_predefined_dba_role to 16/edge June 6, 2025 23:25
…ned_roles_cleanup

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel merged commit 59e6ff2 into 16/edge Jun 8, 2025
479 of 496 checks passed
@marceloneppel marceloneppel deleted the feature/16_predefined_roles_cleanup branch June 8, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, UI change, or workload upgrade Libraries: Out of sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants