-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-7499] Remove admin and postgres roles #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #931 +/- ##
===========================================
+ Coverage 70.22% 70.23% +0.01%
===========================================
Files 16 16
Lines 3725 3723 -2
Branches 542 541 -1
===========================================
- Hits 2616 2615 -1
Misses 974 974
+ Partials 135 134 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…oles' into feature/16_predefined_dba_role Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…oles' into feature/16_predefined_dba_role Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ned_dba_role Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
Q: do we need to change something on pgbouncer after merging this?
We'll need to update the library on PgBouncer through canonical/pgbouncer-operator#549 after merging #921, so that it properly creates the roles when a client app requests a new database to be created by PgBouncer. |
…ned_dba_role Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…into feature/16_predefined_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ned_roles_cleanup Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Issue
The
admin
role should be removed and not available anymore to be used as anextra-user-role
, as different roles were already introduced by #881 and will also be introduced by #921. Those new roles should replace the currently existingadmin
role.The
postgres
user is not used for anything (as we have theoperator
user as the superuser).Solution
Remove the
admin
role and thepostgres
user creation.TODO:
lib/charms/postgresql_k8s/v0/postgresql.py
will be moved tolib/charms/postgresql_k8s/v1/postgresql.py
in a next PR.Checklist