Skip to content

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Sep 26, 2025

Issue

With the new predefined roles implemented for PG 16, if a client app requests a database called databases while the PG charm tries to set up the roles for it, a failure will happen because one of the roles will conflict with the already existing charmed_databases_owner role (responsible for owning all the databases).

Solution

This PR is a follow-up from canonical/postgresql-single-kernel-library#18.

Port of canonical/postgresql-k8s-operator#1108.

The single kernel lib new version, which has the list of invalid databases, was already updated in a previous renovate PR. What this PR updates is the check that unblocks the charm on src/relations/postgresql_provider.py.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

…ownership and permissions

Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel changed the title Update lib to handle new invalid database name and to handle storage … Handle invalid database name Sep 26, 2025
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.53%. Comparing base (45b23a2) to head (3658eaa).
⚠️ Report is 3 commits behind head on 16/edge.

❌ Your project status has failed because the head coverage (64.53%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge    #1190   +/-   ##
========================================
  Coverage    64.53%   64.53%           
========================================
  Files           17       17           
  Lines         4339     4339           
  Branches       671      671           
========================================
  Hits          2800     2800           
  Misses        1357     1357           
  Partials       182      182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marceloneppel marceloneppel added the not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes label Sep 26, 2025
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel changed the title Handle invalid database name [DPE-8473] Handle invalid database name (databases) Oct 2, 2025
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel marked this pull request as ready for review October 9, 2025 11:40
@marceloneppel marceloneppel merged commit d38d765 into 16/edge Oct 9, 2025
317 of 324 checks passed
@marceloneppel marceloneppel deleted the add-invalid-database-name branch October 9, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Libraries: OK not bug or enhancement PR is not 'bug' or 'enhancement'. For release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants