-
Notifications
You must be signed in to change notification settings - Fork 27
[DPE-8473] Handle invalid database name (databases
)
#1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ownership and permissions Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (64.53%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1190 +/- ##
========================================
Coverage 64.53% 64.53%
========================================
Files 17 17
Lines 4339 4339
Branches 671 671
========================================
Hits 2800 2800
Misses 1357 1357
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…se-name Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…se-name Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
databases
)
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…se-name Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…se-name Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Issue
With the new predefined roles implemented for PG 16, if a client app requests a database called databases while the PG charm tries to set up the roles for it, a failure will happen because one of the roles will conflict with the already existing charmed_databases_owner role (responsible for owning all the databases).
Solution
This PR is a follow-up from canonical/postgresql-single-kernel-library#18.
Port of canonical/postgresql-k8s-operator#1108.
The single kernel lib new version, which has the list of invalid databases, was already updated in a previous renovate PR. What this PR updates is the check that unblocks the charm on
src/relations/postgresql_provider.py
.Checklist