Integration test for disable default cni flag #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2024 15:55
maci3jka
changed the title
bschimke95
reviewed
Aug 29, 2024
eaudetcobello
suggested changes
Aug 29, 2024
added 2 commits
September 2, 2024 19:43
bschimke95
reviewed
Sep 3, 2024
|
|
||
| The integration/e2e tests have the following prerequisites: | ||
|
|
||
| * an environment variable `CLUSTER_MANIFEST_FILE` pointing to the cluster manifest. Cluster manifests can be produced with the help of the templates found under `templates`. For example: |
There was a problem hiding this comment.
Are those prerequisites not required anymore?
There was a problem hiding this comment.
yes those are not required they are hardcoded in cluster manifest dir
yest they are used only in tests |
maci3jka
commented
Sep 3, 2024
1 task
eaudetcobello
suggested changes
Sep 4, 2024
removed unnecessary functions
kwmonroe
approved these changes
Sep 9, 2024
Comment on lines
+7
to
+8
| * make sure to have ssh key in aws `capi`in `us-east-1 region` if you do not have key refer | ||
| to CAPI on [AWS prerequisites documentation](https://cluster-api-aws.sigs.k8s.io/topics/using-clusterawsadm-to-fulfill-prerequisites#ssh-key-pair) |
There was a problem hiding this comment.
Suggested change
| * make sure to have ssh key in aws `capi`in `us-east-1 region` if you do not have key refer | |
| to CAPI on [AWS prerequisites documentation](https://cluster-api-aws.sigs.k8s.io/topics/using-clusterawsadm-to-fulfill-prerequisites#ssh-key-pair) | |
| * ensure an AWS ssh key pair named `capi` exists according to the [CAPI Provider AWS documentation](https://cluster-api-aws.sigs.k8s.io/topics/using-clusterawsadm-to-fulfill-prerequisites#ssh-key-pair) |
Co-authored-by: Kevin W Monroe <[email protected]>
maci3jka
force-pushed
the
KU-1226/integration-test-for-disableDefaultCNI-flag
branch
from
7470d77 to
f313dcc
Compare
eaudetcobello
approved these changes
Sep 9, 2024
maci3jka
deleted the
KU-1226/integration-test-for-disableDefaultCNI-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests with disableDefaultCNI set to true for change #110 and improved loging.
Readme fixes.
KU-1226