Skip to content

Conversation

@gabyx
Copy link
Contributor

@gabyx gabyx commented Jun 28, 2025

@domenkozar:

Here a small improvement on the nice Go language module:

  • Make tools compiled with Go optional, for the user to choose what he needs.
    Not sure if the tools.packagesDefault is the right way to go, such that if tools.packages = null its defaulted to tools.packagesDefault

@gabyx gabyx force-pushed the feat/improve-go-language branch from 0d4e90e to c1bae71 Compare June 28, 2025 10:43
@gabyx gabyx force-pushed the feat/improve-go-language branch from c1bae71 to bb3a9a6 Compare June 28, 2025 11:03
@gabyx gabyx force-pushed the feat/improve-go-language branch from 4239254 to 8c59dff Compare June 28, 2025 12:37
@domenkozar
Copy link
Member

I like these changes, I need to think a bit more about the public interface since I'd like it to be universal across all langauges.

Something more like

{
  languages.X.dev.enable = false;
  languages.X.dev.packages.foo.enable = false;
  languages.X.dev.lsp.enable = true;
}

@gabyx
Copy link
Contributor Author

gabyx commented Jul 2, 2025

jeah that would be nice.
so dev.packages beeing a submodule? Shall I try it? or do you wanna add a suggestion?

  • How do tou handle package list which are defaulted to non-empty list, cause its additive merge behavior, not sure about the packagesDefault

@domenkozar
Copy link
Member

@gabyx see #1974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants