Skip to content

fix: replace node12 with node20 runtimes in examples #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix: replace node12 with node20 runtimes in examples #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e25be
fix: replace node12 with node20 runtimes in examples
jsterner30 Mar 4, 2024
b56a91d
fix: upgrade provider block to access nodejs20 runtime for lambdas
jsterner30 Mar 4, 2024
124093c
fix: upgrade old gha modules
jsterner30 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ jobs:
name: Terraform Format
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Terraform Setup
uses: hashicorp/setup-terraform@v2
uses: hashicorp/setup-terraform@v3
with:
terraform_version: 1.0.0

Expand All @@ -67,17 +67,17 @@ jobs:
pull-requests: write
id-token: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v2
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: "arn:aws:iam::${{ matrix.env.aws_account }}:role/${{ matrix.env.aws_gha_role }}"
role-session-name: ${{ github.sha }}
aws-region: us-west-2

- name: Terraform Setup
uses: hashicorp/setup-terraform@v2
uses: hashicorp/setup-terraform@v3
with:
terraform_version: ${{ matrix.env.tf_version }}

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module "lambda_api" {
app_name = "my-lambda-codedeploy-dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"

hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
Expand Down
4 changes: 2 additions & 2 deletions examples/ci-0_13/ci.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
}

provider "aws" {
version = "~> 3.67"
version = "~> 5.33"
region = "us-west-2"
}

Expand All @@ -16,7 +16,7 @@ module "lambda_api" {
app_name = "my-lambda"
zip_filename = "./lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"
hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
vpc_id = module.acs.vpc.id
Expand Down
4 changes: 2 additions & 2 deletions examples/ci-0_14/ci.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
}

provider "aws" {
version = "~> 3.67"
version = "~> 5.33"
region = "us-west-2"
}

Expand All @@ -16,7 +16,7 @@ module "lambda_api" {
app_name = "my-lambda"
zip_filename = "./lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"
hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
vpc_id = module.acs.vpc.id
Expand Down
4 changes: 2 additions & 2 deletions examples/ci-1/ci.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 3.67"
version = "~> 5.33"
}
}
}
Expand All @@ -21,7 +21,7 @@ module "lambda_api" {
app_name = "my-lambda"
zip_filename = "./lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"
hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
vpc_id = module.acs.vpc.id
Expand Down
4 changes: 2 additions & 2 deletions examples/no-codedeploy/example.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
provider "aws" {
version = "~> 3.67"
version = "~> 5.33"
region = "us-west-2"
}

Expand All @@ -13,7 +13,7 @@ module "lambda_api" {
app_name = "my-lambda-dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"
hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
vpc_id = module.acs.vpc.id
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-lambda-in-vpc/example.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module "lambda_api" {
app_name = "my-lambda-dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"

hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
Expand Down
6 changes: 3 additions & 3 deletions examples/simple-lambda-with-deploy-test/example.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
provider "aws" {
version = "~> 3.67"
version = "~> 5.33"
region = "us-west-2"
}

Expand All @@ -14,7 +14,7 @@ module "lambda_api" {
env = "dev"
zip_filename = "./src/lambda.zip"
zip_handler = "index.handler"
zip_runtime = "nodejs12.x"
zip_runtime = "nodejs20.x"

hosted_zone = module.acs.route53_zone
https_certificate_arn = module.acs.certificate.arn
Expand Down Expand Up @@ -61,7 +61,7 @@ resource "aws_lambda_function" "test_lambda" {
function_name = "my-lambda-deploy-test"
role = aws_iam_role.test_lambda.arn
handler = "index.handler"
runtime = "nodejs12.x"
runtime = "nodejs20.x"
timeout = 30
source_code_hash = data.archive_file.cleanup_lambda_zip.output_base64sha256
}
Expand Down