Skip to content

Conversation

@bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Mar 13, 2025

This is required for cg_clif to implement -Zmin-function-alignment.

Required for rust-lang/rustc_codegen_cranelift#1555

…t-jit

It is already handled by MachBuffer. The symbol_alignment could also be
removed as no current backend has a symbol alignment bigger than the
function alignment, but keeping it around is a bit safer when new
backends are introduced.
@bjorn3 bjorn3 requested a review from a team as a code owner March 13, 2025 14:16
@bjorn3 bjorn3 requested review from abrown and removed request for a team March 13, 2025 14:16
@bjorn3 bjorn3 force-pushed the min_code_alignment branch from 177bb36 to bb26381 Compare March 13, 2025 14:28
@bjorn3 bjorn3 requested a review from a team as a code owner March 13, 2025 14:28
@bjorn3 bjorn3 requested review from fitzgen and removed request for a team March 13, 2025 14:28
This is required for cg_clif to implement -Zmin-function-alignment.
@bjorn3 bjorn3 force-pushed the min_code_alignment branch from bb26381 to 7b9336c Compare March 13, 2025 14:35
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:meta Everything related to the meta-language. cranelift:module wasmtime:api Related to the API of the `wasmtime` crate itself labels Mar 13, 2025
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fitzgen fitzgen added this pull request to the merge queue Mar 13, 2025
Merged via the queue into bytecodealliance:main with commit 2af0a1f Mar 13, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:meta Everything related to the meta-language. cranelift:module cranelift Issues related to the Cranelift code generator wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants