add a set of apis to configure wasi via InstantiationArgs2 #4707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i plan to use this to decide which wasi arguments (the one from module or the one from InstantiationArgs2) to use.
fallback to the via-module configuration for now.
yamt
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh and
xujuntwt95329
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, adapt product-mini to use the new api.
for now, the old module-based api is kept for compatibility. we might want to deprecate and remove it at some point in future.
detect mixed uses of old and new api. make instantiation fail in that case.
cf. #4364