-
-
Notifications
You must be signed in to change notification settings - Fork 39
My changes to cmkr #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for all the improvements :) |
…to before the targets
|
I know the changes are getting out of hand a bit 😬, but do you have some comments perhaps? I started using cmkr for everything and I'm slowly integrating features I require. For features that are not yet implemented (or so custom that they should never be implemented) in cmkr I use It still needs a lot of work, but it would be nice if you could take a look and see if this is going in a direction you like. |
|
Hi |
|
Good to hear :) I’m also not a big fan of vendoring dependencies, but in this case I think it’s justified to keep the configure+compile times as low as possible. I’ve been thinking about doing amalgamation as well, but fetching+building cmkr takes only a few seconds now and there are more important things to solve... Currently tests are definitely missing and I collected quite a few TODO comments that need to be addressed eventually. For conditional compilation and platform/compiler specific flags I have the following idea: It will require a bit of work and because of the weird nature of toml tables you can also express this in a very strange alternative syntax, but it seems quite intuitive to me and additionally it allows infinite complexity by injecting cmake and using a variable set there as the condition. |
Comments are welcome 🙂