Skip to content

Update jquery.ui.combobox.js #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update jquery.ui.combobox.js #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions dist/full/jquery.ui.combobox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@

$.widget( "ui.combobox", {

options: {
allowCustomValue: false
},

_setOption: function(key, value) {
if (key === "allowCustomValue") {
options.allowCustomValue = value;
}
this._super(key, value);
},

version: "1.1.1",

widgetEventPrefix: "combobox",
Expand All @@ -55,7 +66,8 @@
.addClass("ui-widget ui-widget-content ui-corner-left ui-combobox-input")
.val( select.children(':selected').text() )
.attr('tabindex', select.attr( 'tabindex'))
.width($(this.element).width());
.width($(this.element).width())
.attr('title', select.children(':selected').text());

wrapper = this.uiCombo =
input.wrap( '<span>' )
Expand All @@ -70,10 +82,11 @@
minLength: 0,

appendTo: wrapper,
source: $.proxy( this, "_linkSelectList" )
source: $.proxy( this, "_linkSelectList" ),
select: function(event, ui) {
var selectedObj = ui.item;
$(this).attr('title', ui.item.value)
}
});

$( "<button>" )
Expand Down Expand Up @@ -139,7 +152,8 @@
var changedOption = ui.item ? ui.item.option : null;
if ( !ui.item ) {

var matcher = new RegExp( "^" + $.ui.autocomplete.escapeRegex( $el.val() ) + "$", "i" ),
var text = $el.val();
var matcher = new RegExp("^" + $.ui.autocomplete.escapeRegex(text) + "$", "i"),
valid = false,
matchContains = null,
iContains = 0,
Expand Down Expand Up @@ -180,8 +194,14 @@
console.log("Found single match with '" + t2 + "'");
} else {

// remove invalid value, as it didn't match anything
$el.val( '' );
if(this.options.allowCustomValue === true)
{
// Update title and value for new string in input
$el.attr('title', text);
} else {
// remove invalid value, as it didn't match anything
$el.val('');
}

// Internally, term must change before another search is performed
// if the same search is performed again, the menu won't be shown
Expand Down Expand Up @@ -256,11 +276,16 @@
this.uiInput.attr('title', select.children(':selected').text())
} else {
this.uiInput.val( "" );
this.uiInput.attr('title', "");
this.element.prop('selectedIndex', -1);
}

},

title: function () {
return this.uiInput.attr('title');
},

_destroy: function () {
this.element.show();
this.uiCombo.replaceWith( this.element );
Expand Down