bhyve VM Support #605
Merged
bhyve VM Support #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gronke
force-pushed
the
feature/bhyve
branch
2 times, most recently
from
0f01dcd to
505cac4
Compare
igalic
reviewed
Jan 10, 2019
ioc/Jail.py
Outdated
| ) | ||
| devfs_ruleset.append("add path vmm unhide") | ||
| devfs_ruleset.append("add path vmm/* unhide") | ||
| devfs_ruleset.append("add path nmdm* unhide") |
There was a problem hiding this comment.
this is also missing from iocage/iocage#767
gronke
force-pushed
the
feature/bhyve
branch
3 times, most recently
from
bd2e62f to
7f4f461
Compare
igalic
requested changes
Jan 10, 2019
ioc/Jail.py
Outdated
| @@ -1602,6 +1602,11 @@ def devfs_ruleset(self) -> ioc.DevfsRules.DevfsRuleset: | |||
| if self._allow_mount_zfs == "1": | |||
| devfs_ruleset.append("add path zfs unhide") | |||
|
|
|||
| if self.config["allow_vmm"] is True: | |||
| devfs_ruleset.append("add path vmm unhide") | |||
| devfs_ruleset.append("add path vmm/* unhide") | |||
There was a problem hiding this comment.
as discussed elsewhere, it would be good to create a concrete rule per vmm container, rather than exposing all these devices to each jail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #604
blocked by #644